Issue 10386071: Assign a short name to private variables (first one wins).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10386071: Assign a short name to private variables (first one wins). (Closed)

Created:
8 years, 7 months ago by floitsch

Modified:
8 years, 7 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Assign a short name to private variables (first one wins). Committed: https://code.google.com/p/dart/source/detail?r=7489

Patch Set 2 : Address comment. #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -4 lines)			Patch
	M	lib/compiler/implementation/namer.dart	View	1	4 chunks	+23 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://chromiumcodereview.appspot.com/10386071/diff/1/lib/compiler/implementation/namer.dart File lib/compiler/implementation/namer.dart (right): https://chromiumcodereview.appspot.com/10386071/diff/1/lib/compiler/implementation/namer.dart#newcode45 lib/compiler/implementation/namer.dart:45: bool canNotClashWithMangledPrivateNames(String proposedName) { I'd inline the closure, ...

8 years, 7 months ago (2012-05-10 14:20:41 UTC) #2

floitsch

8 years, 7 months ago (2012-05-10 14:33:01 UTC) #3

https://chromiumcodereview.appspot.com/10386071/diff/1/lib/compiler/implement...
File lib/compiler/implementation/namer.dart (right):

https://chromiumcodereview.appspot.com/10386071/diff/1/lib/compiler/implement...
lib/compiler/implementation/namer.dart:45: bool
canNotClashWithMangledPrivateNames(String proposedName) {
On 2012/05/10 14:20:41, ngeoffray wrote:
> I'd inline the closure, and add a comment instead of encoding the comment in
the
> closure name.

Done.

Expand Messages | Collapse Messages

Issue 10386071: Assign a short name to private variables (first one wins). (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comment. #

Messages