Issue 10386040: Avoid using chunked transfer encoding when the HTTP verision is 1.0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10386040: Avoid using chunked transfer encoding when the HTTP verision is 1.0. (Closed)

Created:
8 years, 7 months ago by Søren Gjesse

Modified:
8 years, 7 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Avoid using chunked transfer encoding when the HTTP verision is 1.0. R=ager@google.com BUG=dart:2938 TEST=tests/standalone/io/http_content_length_test.dart Committed: https://code.google.com/p/dart/source/detail?r=7442

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -0 lines)			Patch
M	runtime/bin/http.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/bin/http_impl.dart	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	tests/standalone/io/http_content_length_test.dart	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

lgtm https://chromiumcodereview.appspot.com/10386040/diff/1/tests/standalone/io/http_content_length_test.dart File tests/standalone/io/http_content_length_test.dart (right): https://chromiumcodereview.appspot.com/10386040/diff/1/tests/standalone/io/http_content_length_test.dart#newcode99 tests/standalone/io/http_content_length_test.dart:99: socket.onClosed = () { Indentation is off.

8 years, 7 months ago (2012-05-09 07:42:14 UTC) #2

Søren Gjesse

8 years, 7 months ago (2012-05-09 08:57:02 UTC) #3

https://chromiumcodereview.appspot.com/10386040/diff/1/tests/standalone/io/ht...
File tests/standalone/io/http_content_length_test.dart (right):

https://chromiumcodereview.appspot.com/10386040/diff/1/tests/standalone/io/ht...
tests/standalone/io/http_content_length_test.dart:99: socket.onClosed = () {
On 2012/05/09 07:42:14, Mads Ager wrote:
> Indentation is off.

Done.

Expand Messages | Collapse Messages