Issue 10386039: Add indexOf to Int/Float-List's.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10386039: Add indexOf to Int/Float-List's. (Closed)

Created:
8 years, 7 months ago by Anders Johnsen

Modified:
8 years, 7 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add indexOf to Int/Float-List's. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7439

Patch Set 2 : Removed var. #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -0 lines)			Patch
	M	runtime/lib/byte_array.dart	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
	M	tests/standalone/byte_array_test.dart	View		1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Hi Soeren, Can you review this CL for me? The motivation for this patch is ...

8 years, 7 months ago (2012-05-09 07:04:33 UTC) #1

Søren Gjesse

lgtm https://chromiumcodereview.appspot.com/10386039/diff/1/runtime/lib/byte_array.dart File runtime/lib/byte_array.dart (right): https://chromiumcodereview.appspot.com/10386039/diff/1/runtime/lib/byte_array.dart#newcode263 runtime/lib/byte_array.dart:263: int indexOf(var element, [int start = 0]) { ...

8 years, 7 months ago (2012-05-09 07:08:03 UTC) #2