Issue 10386010: Add enumeration of the HTTP headers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10386010: Add enumeration of the HTTP headers (Closed)

Created:
8 years, 7 months ago by Søren Gjesse

Modified:
8 years, 7 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add enumeration of the HTTP headers R=ajohnsen@google.com BUG=dart:2045 TEST=tests/standalone/io/http_headers_test.dart Committed: https://code.google.com/p/dart/source/detail?r=7377

Patch Set 1 #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -0 lines)			Patch
M	runtime/bin/http.dart	View	1 chunk	+7 lines, -0 lines	2 comments	Download
M	runtime/bin/http_impl.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/standalone/io/http_headers_test.dart	View	1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM, neat! https://chromiumcodereview.appspot.com/10386010/diff/1/runtime/bin/http.dart File runtime/bin/http.dart (right): https://chromiumcodereview.appspot.com/10386010/diff/1/runtime/bin/http.dart#newcode274 runtime/bin/http.dart:274: * header. The header names in passed ...

8 years, 7 months ago (2012-05-07 13:21:27 UTC) #2

Søren Gjesse

8 years, 7 months ago (2012-05-07 13:51:46 UTC) #3

https://chromiumcodereview.appspot.com/10386010/diff/1/runtime/bin/http.dart
File runtime/bin/http.dart (right):

https://chromiumcodereview.appspot.com/10386010/diff/1/runtime/bin/http.dart#...
runtime/bin/http.dart:274: * header. The header names in passed in [name] will
be all lower
On 2012/05/07 13:21:27, ajohnsen wrote:
> This sounds odd. :)

The HTTP header names are case insensitive (defined in the spec.). For
simplicity they are internally converted to all lowercase and the original
string thrown away.

Expand Messages | Collapse Messages