Issue 10384081: Remove dependence on samples from runtime checkout, mistakenly added by r7412

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10384081: Remove dependence on samples from runtime checkout, mistakenly added by r7412 (Closed)

Created:
8 years, 7 months ago by Bill Hesse

Modified:
8 years, 7 months ago

Reviewers:
Mads Ager (google), Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Remove dependence on samples from runtime checkout, mistakenly added by r7412 BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7464

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	dart.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	runtime/dart-runtime.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Mads Ager (google)

LGTM, thanks. We should add a separate build target for samples that depends on runtime. ...

8 years, 7 months ago (2012-05-09 14:16:48 UTC) #2

LGTM -ip