Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 10384024: Element constructors (Closed)

Created:
8 years, 7 months ago by sra1
Modified:
8 years, 7 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org, Jacob
Visibility:
Public.

Description

Element constructors Elements with distinct types can now be constructed directly. Example: var div = new DivElement(); There are many elements that cannot be created this way. For example, the <b>bold</b> element is simply a HTMLElement with styling, not a separate subclass of HTMLElement. Committed: https://code.google.com/p/dart/source/detail?r=7921

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+993 lines, -96 lines) Patch
M lib/dom/scripts/systemhtml.py View 5 chunks +126 lines, -0 lines 0 comments Download
A lib/dom/templates/html/interface/factoryprovider__Elements.darttemplate View 1 chunk +8 lines, -0 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 49 chunks +399 lines, -48 lines 0 comments Download
M lib/html/frog/html_frog.dart View 49 chunks +399 lines, -48 lines 0 comments Download
A tests/html/element_constructor_1_test.dart View 1 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
8 years, 7 months ago (2012-05-23 04:32:44 UTC) #1
vsm
8 years, 7 months ago (2012-05-23 04:46:06 UTC) #2
LGTM!

https://chromiumcodereview.appspot.com/10384024/diff/4003/tests/html/element_...
File tests/html/element_constructor_1_test.dart (right):

https://chromiumcodereview.appspot.com/10384024/diff/4003/tests/html/element_...
tests/html/element_constructor_1_test.dart:37: });
Minor nit: add a test for CanvasElement or some other type that has constructor
params.

Powered by Google App Engine
This is Rietveld 408576698