Move dart:dom implementation classes to dart:html library.

Move dart:dom implementation classes to dart:html library.

Rename dom implementation classes to _<Interface>DOMImpl to avoid clashes with html
implementation classes, and import dom implementation classes directly into dart:html.
Temporary introduce fake dom interfaces for overload dispatching (dom implementation classes
don't implement html interfaces yet).

R=antonm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=7954

[Anton Muhin, 2012-05-23 14:03:31]

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/scripts/dartdo...
File lib/dom/scripts/dartdomgenerator.py (right):

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/scripts/dartdo...
lib/dom/scripts/dartdomgenerator.py:160: elif system == 'native':
do we need to support it now?

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systemnative.py (right):

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemnative.py:387: def _DartType(self, idl_type):
shouldn't this logic belong to IDLTypeInfo?

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemnative.py:452: parameters =
constructor_info.ParametersImplementationDeclaration(lambda x:
self._DartType(x))
nit: no need in lambda, self._DartType should work too

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/src/native_DOM...
File lib/dom/src/native_DOMWrapperBase.dart (right):

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/src/native_DOM...
lib/dom/src/native_DOMWrapperBase.dart:8: String get typeName() => "";
why this getter?

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/templates/dom/...
File lib/dom/templates/dom/native/dart_implementation.darttemplate (right):

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/templates/dom/...
lib/dom/templates/dom/native/dart_implementation.darttemplate:16:
_create$CLASS() => new $CLASS._create$CLASS();
why those are not static methods?

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/templates/html...
File lib/dom/templates/html/dartium/factoryprovider_CSSMatrix.darttemplate
(left):

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/templates/html...
lib/dom/templates/html/dartium/factoryprovider_CSSMatrix.darttemplate:6: factory
CSSMatrix([String cssValue = '']) =>
it used to have an optional arg, is it still fine with this change?

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/templates/html...
File lib/dom/templates/html/dartium/impl_EventTarget.darttemplate (right):

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/templates/html...
lib/dom/templates/html/dartium/impl_EventTarget.darttemplate:14: return
_get(type);
why this change?

[podivilov, 2012-05-23 14:52:40]

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/scripts/dartdo...
File lib/dom/scripts/dartdomgenerator.py (right):

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/scripts/dartdo...
lib/dom/scripts/dartdomgenerator.py:160: elif system == 'native':
On 2012/05/23 14:03:31, antonmuhin wrote:
> do we need to support it now?

Let me do the cleanup in a separate change. This one is pretty huge already.

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systemnative.py (right):

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemnative.py:387: def _DartType(self, idl_type):
On 2012/05/23 14:03:31, antonmuhin wrote:
> shouldn't this logic belong to IDLTypeInfo?

This is temporary, only needed because dom wrappers don't implement html
interfaces yet.

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemnative.py:452: parameters =
constructor_info.ParametersImplementationDeclaration(lambda x:
self._DartType(x))
On 2012/05/23 14:03:31, antonmuhin wrote:
> nit: no need in lambda, self._DartType should work too

Done.

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/src/native_DOM...
File lib/dom/src/native_DOMWrapperBase.dart (right):

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/src/native_DOM...
lib/dom/src/native_DOMWrapperBase.dart:8: String get typeName() => "";
On 2012/05/23 14:03:31, antonmuhin wrote:
> why this getter?

It is used in _wrap. Was previously declared on DOMType.

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/templates/dom/...
File lib/dom/templates/dom/native/dart_implementation.darttemplate (right):

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/templates/dom/...
lib/dom/templates/dom/native/dart_implementation.darttemplate:16:
_create$CLASS() => new $CLASS._create$CLASS();
On 2012/05/23 14:03:31, antonmuhin wrote:
> why those are not static methods?

Because of the bug with Dart_GetClass for private claseses.

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/templates/html...
File lib/dom/templates/html/dartium/factoryprovider_CSSMatrix.darttemplate
(left):

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/templates/html...
lib/dom/templates/html/dartium/factoryprovider_CSSMatrix.darttemplate:6: factory
CSSMatrix([String cssValue = '']) =>
On 2012/05/23 14:03:31, antonmuhin wrote:
> it used to have an optional arg, is it still fine with this change?

It was custom just because WebKitCSSMatrix->CSSMatrix rename.

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/templates/html...
File lib/dom/templates/html/dartium/impl_EventTarget.darttemplate (right):

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/templates/html...
lib/dom/templates/html/dartium/impl_EventTarget.darttemplate:14: return
_get(type);
On 2012/05/23 14:03:31, antonmuhin wrote:
> why this change?

It was a bug that prevented access to non lowercase events via [] syntax.

[Anton Muhin, 2012-05-23 15:25:23]

lgtm w/ comments addressed

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/scripts/dartdo...
File lib/dom/scripts/dartdomgenerator.py (right):

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/scripts/dartdo...
lib/dom/scripts/dartdomgenerator.py:160: elif system == 'native':
I'd rather see this CL split into several parts like nuking unnecessary factory
providers templates etc. :)

Please, add a TODO

On 2012/05/23 14:52:40, podivilov wrote:
> On 2012/05/23 14:03:31, antonmuhin wrote:
> > do we need to support it now?
> 
> Let me do the cleanup in a separate change. This one is pretty huge already.

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systemnative.py (right):

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemnative.py:387: def _DartType(self, idl_type):
Please, add a TODO w/ explanations

On 2012/05/23 14:52:40, podivilov wrote:
> On 2012/05/23 14:03:31, antonmuhin wrote:
> > shouldn't this logic belong to IDLTypeInfo?
> 
> This is temporary, only needed because dom wrappers don't implement html
> interfaces yet.

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/src/native_DOM...
File lib/dom/src/native_DOMWrapperBase.dart (right):

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/src/native_DOM...
lib/dom/src/native_DOMWrapperBase.dart:8: String get typeName() => "";
If it's overridden by subclasses, why we need to provide such an implementation?
 Maybe declare abstract or throw an exception instead?

On 2012/05/23 14:52:40, podivilov wrote:
> On 2012/05/23 14:03:31, antonmuhin wrote:
> > why this getter?
> 
> It is used in _wrap. Was previously declared on DOMType.

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/templates/html...
File lib/dom/templates/html/dartium/impl_EventTarget.darttemplate (right):

https://chromiumcodereview.appspot.com/10383302/diff/1/lib/dom/templates/html...
lib/dom/templates/html/dartium/impl_EventTarget.darttemplate:14: return
_get(type);
please, a separate CL.

On 2012/05/23 14:52:40, podivilov wrote:
> On 2012/05/23 14:03:31, antonmuhin wrote:
> > why this change?
> 
> It was a bug that prevented access to non lowercase events via [] syntax.

https://chromiumcodereview.appspot.com/10383302/diff/1018/lib/dom/scripts/dar...
File lib/dom/scripts/dartdomgenerator.py (right):

https://chromiumcodereview.appspot.com/10383302/diff/1018/lib/dom/scripts/dar...
lib/dom/scripts/dartdomgenerator.py:143: native_system =
NativeImplementationSystem(
that probably should go directly into HTMLDartium, correct?  if yes, please, add
a TODO

[podivilov, 2012-05-24 10:33:07]

http://codereview.chromium.org/10383302/diff/1/lib/dom/scripts/dartdomgenerat...
File lib/dom/scripts/dartdomgenerator.py (right):

http://codereview.chromium.org/10383302/diff/1/lib/dom/scripts/dartdomgenerat...
lib/dom/scripts/dartdomgenerator.py:160: elif system == 'native':
On 2012/05/23 15:25:23, antonmuhin wrote:
> I'd rather see this CL split into several parts like nuking unnecessary
factory
> providers templates etc. :)
> 
> Please, add a TODO
> 
> On 2012/05/23 14:52:40, podivilov wrote:
> > On 2012/05/23 14:03:31, antonmuhin wrote:
> > > do we need to support it now?
> > 
> > Let me do the cleanup in a separate change. This one is pretty huge already.
> 

Done.

http://codereview.chromium.org/10383302/diff/1/lib/dom/scripts/systemnative.py
File lib/dom/scripts/systemnative.py (right):

http://codereview.chromium.org/10383302/diff/1/lib/dom/scripts/systemnative.p...
lib/dom/scripts/systemnative.py:387: def _DartType(self, idl_type):
On 2012/05/23 15:25:23, antonmuhin wrote:
> Please, add a TODO w/ explanations
> 
> On 2012/05/23 14:52:40, podivilov wrote:
> > On 2012/05/23 14:03:31, antonmuhin wrote:
> > > shouldn't this logic belong to IDLTypeInfo?
> > 
> > This is temporary, only needed because dom wrappers don't implement html
> > interfaces yet.
> 

Done.

http://codereview.chromium.org/10383302/diff/1/lib/dom/src/native_DOMWrapperB...
File lib/dom/src/native_DOMWrapperBase.dart (right):

http://codereview.chromium.org/10383302/diff/1/lib/dom/src/native_DOMWrapperB...
lib/dom/src/native_DOMWrapperBase.dart:8: String get typeName() => "";
On 2012/05/23 15:25:23, antonmuhin wrote:
> If it's overridden by subclasses, why we need to provide such an
implementation?
>  Maybe declare abstract or throw an exception instead?
> 
> On 2012/05/23 14:52:40, podivilov wrote:
> > On 2012/05/23 14:03:31, antonmuhin wrote:
> > > why this getter?
> > 
> > It is used in _wrap. Was previously declared on DOMType.
> 

Done.

http://codereview.chromium.org/10383302/diff/1/lib/dom/templates/html/dartium...
File lib/dom/templates/html/dartium/impl_EventTarget.darttemplate (right):

http://codereview.chromium.org/10383302/diff/1/lib/dom/templates/html/dartium...
lib/dom/templates/html/dartium/impl_EventTarget.darttemplate:14: return
_get(type);
On 2012/05/23 15:25:23, antonmuhin wrote:
> please, a separate CL.
> 
> On 2012/05/23 14:52:40, podivilov wrote:
> > On 2012/05/23 14:03:31, antonmuhin wrote:
> > > why this change?
> > 
> > It was a bug that prevented access to non lowercase events via [] syntax.
> 

Done.

http://codereview.chromium.org/10383302/diff/1018/lib/dom/scripts/dartdomgene...
File lib/dom/scripts/dartdomgenerator.py (right):

http://codereview.chromium.org/10383302/diff/1018/lib/dom/scripts/dartdomgene...
lib/dom/scripts/dartdomgenerator.py:143: native_system =
NativeImplementationSystem(
On 2012/05/23 15:25:23, antonmuhin wrote:
> that probably should go directly into HTMLDartium, correct?  if yes, please,
add
> a TODO

Not sure. They use different databases, and such a move will require a massive
refactoring.

[Anton Muhin, 2012-05-24 13:11:23]

lgtm