Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 10383252: Script to generate all systems (Closed)

Created:
8 years, 7 months ago by sra1
Modified:
8 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Script to generate some or all systems I find it essential to generate all the systems in one command. I have several CLs in flight where I am changing dart:dom and dart:html together. My habit is to run: ./go.sh | tee Q I can inspect file Q if needed. If I know the IDL has not changed, it is 5x faster to run ./go.sh --cached Systems can be picked: ./go.sh native,frog The missing piece here is that files are generated under two directories lib/dom/generated/ lib/html/generated/ I propose that we move all the generated files under one directory, so that the following process gives a *complete* picture of the changes: git checkout master ./go.sh mv ../generated ../generated0 git checkout work ./go.sh meld ../generated0 ../generated Committed: https://code.google.com/p/dart/source/detail?r=7773

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
A lib/dom/scripts/go.sh View 1 chunk +53 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
sra1
I would like to recover the ability to generate everything in one command. For new ...
8 years, 7 months ago (2012-05-18 21:08:23 UTC) #1
vsm
Why bash instead of python? I don't think we have bash in the repo right ...
8 years, 7 months ago (2012-05-18 21:19:22 UTC) #2
sra1
On 2012/05/18 21:19:22, vsm wrote: > Why bash instead of python? I don't think we ...
8 years, 7 months ago (2012-05-18 21:50:51 UTC) #3
vsm
LGTM, but please add a comment that this is a convenience script and shouldn't be ...
8 years, 7 months ago (2012-05-18 22:04:38 UTC) #4
podivilov
Stephen, This script currently works for me. Could you please clarify what exactly is missing? ...
8 years, 7 months ago (2012-05-21 10:56:10 UTC) #5
sra1
My apologies - I misunderstood something because of the if-then-else and seeing the IDL being ...
8 years, 7 months ago (2012-05-21 16:31:17 UTC) #6
podivilov
8 years, 7 months ago (2012-05-21 18:39:10 UTC) #7
Maybe we can have just a single system "systemhtml" which generate dart:html
interfaces and implementations in one pass. It could generate a dart interface
right away, and use a frog/dartium subgenerator to generate corresponding
implementation. And the same for "systemdom". That way there will be less code
duplication. WDYT?

I think deleting generated directory is the right thing to do, as I remember it
used to work that way some time ago.

Powered by Google App Engine
This is Rietveld 408576698