Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 10383238: Fix tests in language suite: eliminate String + (Closed)

Created:
8 years, 7 months ago by hausner
Modified:
8 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix tests in language suite: eliminate String + The language suite runs clean without String + after this change. string_concat_test.dart is obsolete, removed. Committed: https://code.google.com/p/dart/source/detail?r=7745

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -112 lines) Patch
M runtime/bin/builtin.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/date.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/call_through_null_getter_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/const_string_test.dart View 1 chunk +17 lines, -17 lines 0 comments Download
M tests/language/final_syntax_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/pseudo_kw_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/reg_ex2_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/reg_exp2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/savannah_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
D tests/language/string_concat_test.dart View 1 chunk +0 lines, -70 lines 0 comments Download
M tests/language/super_field_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/language/super_setter_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/top_level_func_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/type_checks_in_factory_method_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
hausner
8 years, 7 months ago (2012-05-18 01:06:23 UTC) #1
siva
8 years, 7 months ago (2012-05-18 01:15:39 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698