Issue 10383179: Start 'fuzzing' of dart:io APIs and fix first issue found.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10383179: Start 'fuzzing' of dart:io APIs and fix first issue found. (Closed)

Created:
8 years, 7 months ago by Mads Ager (google)

Modified:
8 years, 7 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Start 'fuzzing' of dart:io APIs and fix first issue found. Deserialize unsupported Dart objects to Dart_CObject of type kUnsupported instead of NULL pointers. That way the normal Dart_CObject validation that tests for supported types will work out of the box and not crash the VM. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7645

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -20 lines)			Patch
M	runtime/include/dart_api.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/dart_api_message.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_message.cc	View	7 chunks	+26 lines, -20 lines	0 comments	Download
A	tests/standalone/io/file_fuzz_test.dart	View	1 chunk	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages