Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 10383122: Eliminate need for va_copy in json.cc (Closed)

Created:
8 years, 7 months ago by hausner
Modified:
8 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Eliminate need for va_copy in json.cc The hacked version of va_copy did not work on Linux. Committed: https://code.google.com/p/dart/source/detail?r=7525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -30 lines) Patch
M runtime/bin/dbg_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/dbg_connection.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M runtime/platform/json.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/platform/json.cc View 3 chunks +6 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
hausner
8 years, 7 months ago (2012-05-10 23:23:14 UTC) #1
siva
8 years, 7 months ago (2012-05-10 23:27:54 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698