Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 10383086: Implement --help option and generalize option parsing. (Closed)

Created:
8 years, 7 months ago by ahe
Modified:
8 years, 7 months ago
Reviewers:
sethladd, kasperl, kathyw
CC:
reviews_dartlang.org, lukeechurch_googlemail.com, bakster, Kathy Walrath, sethladd
Visibility:
Public.

Description

Implement --help option and generalize option parsing. Committed: https://code.google.com/p/dart/source/detail?r=7461

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -29 lines) Patch
M dart/lib/compiler/implementation/dart2js.dart View 5 chunks +95 lines, -29 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
ahe
Kathy, Seth, and Luke: I would like your opinion on the error message. Here are ...
8 years, 7 months ago (2012-05-09 14:09:36 UTC) #1
kasperl
LGTM.
8 years, 7 months ago (2012-05-09 14:13:53 UTC) #2
kathyw
How about: e 1. Running the compiler without any arguments: $ dart2js Usage: dart2js [OPTIONS] ...
8 years, 7 months ago (2012-05-09 18:01:10 UTC) #3
kathyw
The spacing is strange in email (though not in https://chromiumcodereview.appspot.com/10383086/). Basically, I tried to reduce ...
8 years, 7 months ago (2012-05-09 18:04:11 UTC) #4
kathyw
Another thing I just noticed: default is out.js -> default: ./out.js (specify the current directory, ...
8 years, 7 months ago (2012-05-09 18:06:05 UTC) #5
sethladd
8 years, 7 months ago (2012-05-09 18:08:12 UTC) #6
https://chromiumcodereview.appspot.com/10383086/diff/2001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/dart2js.dart (right):

https://chromiumcodereview.appspot.com/10383086/diff/2001/dart/lib/compiler/i...
dart/lib/compiler/implementation/dart2js.dart:201: --out=FILE  Save the output
to FILE (default is out.js).
I believe the new dart.js file that Kasper updated expects dart2js output to be
of file.js_  This expectation does not match the default out.js

Powered by Google App Engine
This is Rietveld 408576698