Issue 10383049: Revert "Using arg parsing lib for dart2js."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10383049: Revert "Using arg parsing lib for dart2js." (Closed)

Created:
8 years, 7 months ago by Bob Nystrom

Modified:
8 years, 7 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Using arg parsing lib for dart2js." This reverts commit 825af47550b15b336d133ea466b3a547737e79be. Committed: https://code.google.com/p/dart/source/detail?r=7394

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -165 lines)			Patch
M	lib/args/args.dart	View	8 chunks	+10 lines, -54 lines	0 comments	Download
M	lib/compiler/implementation/dart2js.dart	View	3 chunks	+35 lines, -44 lines	0 comments	Download
M	tests/lib/args/args_test.dart	View	13 chunks	+24 lines, -67 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm, for disappointed values of good (disappointed that we had to revert. :-) )

8 years, 7 months ago (2012-05-07 19:54:52 UTC) #2

Bob Nystrom

8 years, 7 months ago (2012-05-07 19:55:42 UTC) #3

On 2012/05/07 19:54:52, Emily Fortuna wrote:
> lgtm, for disappointed values of good (disappointed that we had to revert. :-)
)

I'll get it back in. I just need to tweak the test framework to actually invoke
dart2js with valid arguments. :)

Expand Messages | Collapse Messages