Issue 10383041: Add CryptoUtils class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10383041: Add CryptoUtils class. (Closed)

Created:
8 years, 7 months ago by Mads Ager (google)

Modified:
8 years, 7 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add CryptoUtils class. Currently only contains digestToHex to convert a message digest to a hex string. R=sgjesse@google.com BUG=dartbug.com/2839 TEST= Committed: https://code.google.com/p/dart/source/detail?r=7384

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -40 lines)			Patch
M	lib/crypto/crypto.dart	View	1	3 chunks	+13 lines, -1 line	0 comments	Download
A	lib/crypto/crypto_utils.dart	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	tests/lib/crypto/hmac_sha1_test.dart	View	1	1 chunk	+1 line, -9 lines	0 comments	Download
M	tests/lib/crypto/hmac_sha256_test.dart	View	1	1 chunk	+1 line, -9 lines	0 comments	Download
M	tests/lib/crypto/sha1_test.dart	View	1	3 chunks	+3 lines, -11 lines	0 comments	Download
M	tests/lib/crypto/sha256_test.dart	View	1	3 chunks	+2 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://chromiumcodereview.appspot.com/10383041/diff/1/lib/crypto/crypto.dart File lib/crypto/crypto.dart (right): https://chromiumcodereview.appspot.com/10383041/diff/1/lib/crypto/crypto.dart#newcode95 lib/crypto/crypto.dart:95: static String digestToHex(List<int> digest) { Shouldn't this just ...

8 years, 7 months ago (2012-05-07 14:26:34 UTC) #2

Mads Ager (google)

8 years, 7 months ago (2012-05-07 14:34:59 UTC) #3

https://chromiumcodereview.appspot.com/10383041/diff/1/lib/crypto/crypto.dart
File lib/crypto/crypto.dart (right):

https://chromiumcodereview.appspot.com/10383041/diff/1/lib/crypto/crypto.dart...
lib/crypto/crypto.dart:95: static String digestToHex(List<int> digest) {
On 2012/05/07 14:26:34, Søren Gjesse wrote:
> Shouldn't this just be bytesToHex? This can be used for more than just
digests.
> For crypto input can also be for instance keys.

Good point. Done.

Expand Messages | Collapse Messages