Add more API fuzzing and fix the issues encountered.

Add more API fuzzing and fix the issues encountered.

- Fixed integer checks in a couple of places.
- Added closed checks to async operations.

More changes like this coming but I'm splitting the work up to not
make the review too large.

R=sgjesse@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=7683

[Søren Gjesse, 2012-05-16 11:54:11]

lgtm

https://chromiumcodereview.appspot.com/10382194/diff/1/runtime/bin/file.cc
File runtime/bin/file.cc (right):

https://chromiumcodereview.appspot.com/10382194/diff/1/runtime/bin/file.cc#ne...
runtime/bin/file.cc:137: ASSERT(file != NULL);
How about adding a function to do this

int64_t value;
bool valid_argument = DartUtils::SetInt64Value(value_handle, &value);
if (valid_argument) {
  ...


or even


int64_t value;
if (DartUtils::SetInt64Value(value_handle, &value)) {
  ...

https://chromiumcodereview.appspot.com/10382194/diff/1/runtime/bin/file.cc#ne...
runtime/bin/file.cc:204: result =
Fits one line?

https://chromiumcodereview.appspot.com/10382194/diff/1/runtime/bin/file.cc#ne...
runtime/bin/file.cc:230: DartUtils::GetIntegerValue(Dart_GetNativeArgument(args,
2));
Shouldn't we check more here? DartUtils::GetIntegerValue use a number of asserts
- like for WriteByte above?

https://chromiumcodereview.appspot.com/10382194/diff/1/runtime/bin/file_impl....
File runtime/bin/file_impl.dart (right):

https://chromiumcodereview.appspot.com/10382194/diff/1/runtime/bin/file_impl....
runtime/bin/file_impl.dart:759: if (_isClosed) {
Add a function for closed exception as 4 lines of code are repeated below.

[Mads Ager (google), 2012-05-16 12:45:19]

https://chromiumcodereview.appspot.com/10382194/diff/1/runtime/bin/file.cc
File runtime/bin/file.cc (right):

https://chromiumcodereview.appspot.com/10382194/diff/1/runtime/bin/file.cc#ne...
runtime/bin/file.cc:137: ASSERT(file != NULL);
On 2012/05/16 11:54:11, Søren Gjesse wrote:
> How about adding a function to do this
> 
> int64_t value;
> bool valid_argument = DartUtils::SetInt64Value(value_handle, &value);
> if (valid_argument) {
>   ...
> 
> 
> or even
> 
> 
> int64_t value;
> if (DartUtils::SetInt64Value(value_handle, &value)) {
>   ...

Maybe we should just change GetIntegerValue to do this. I have added a
GetInt64Value that checks. I have kept GetIntegerValue for now. I will phase out
its use going forward.

https://chromiumcodereview.appspot.com/10382194/diff/1/runtime/bin/file.cc#ne...
runtime/bin/file.cc:204: result =
On 2012/05/16 11:54:11, Søren Gjesse wrote:
> Fits one line?

Done.

https://chromiumcodereview.appspot.com/10382194/diff/1/runtime/bin/file.cc#ne...
runtime/bin/file.cc:230: DartUtils::GetIntegerValue(Dart_GetNativeArgument(args,
2));
On 2012/05/16 11:54:11, Søren Gjesse wrote:
> Shouldn't we check more here? DartUtils::GetIntegerValue use a number of
asserts
> - like for WriteByte above?

Oh, yes, here and many other places. I just haven't gotten around to this one
yet. I just change the file != NULL case to an assert. Stay tuned for this one.
:)

https://chromiumcodereview.appspot.com/10382194/diff/1/runtime/bin/file_impl....
File runtime/bin/file_impl.dart (right):

https://chromiumcodereview.appspot.com/10382194/diff/1/runtime/bin/file_impl....
runtime/bin/file_impl.dart:759: if (_isClosed) {
On 2012/05/16 11:54:11, Søren Gjesse wrote:
> Add a function for closed exception as 4 lines of code are repeated below.

Done. Each of these replaced by:

if (_isClosed) return _completeWithClosedException(completer);