Issue 10382176: Add test for DOM fileapi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10382176: Add test for DOM fileapi. (Closed)

Created:
8 years, 7 months ago by podivilov

Modified:
8 years, 7 months ago

Reviewers:
Anton Muhin, antonm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add test for DOM fileapi. R=antonm@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=7686

Patch Set 2 : . #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -0 lines)			Patch
	A	tests/html/fileapi_test.dart	View	1	1 chunk	+66 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

LGTM https://chromiumcodereview.appspot.com/10382176/diff/1/tests/html/fileapi_test.dart File tests/html/fileapi_test.dart (right): https://chromiumcodereview.appspot.com/10382176/diff/1/tests/html/fileapi_test.dart#newcode13 tests/html/fileapi_test.dart:13: fs.root.getDirectory('directory2', {}, (e) { this is very hard ...

8 years, 7 months ago (2012-05-15 18:32:23 UTC) #2

podivilov

8 years, 7 months ago (2012-05-16 13:49:25 UTC) #3

https://chromiumcodereview.appspot.com/10382176/diff/1/tests/html/fileapi_tes...
File tests/html/fileapi_test.dart (right):

https://chromiumcodereview.appspot.com/10382176/diff/1/tests/html/fileapi_tes...
tests/html/fileapi_test.dart:13: fs.root.getDirectory('directory2', {}, (e) {
On 2012/05/15 18:32:23, antonmuhin wrote:
> this is very hard to read, but luckily starting from 2nd, arguments are named,
> may you use those names?
> 
> fs.root.getDirectory('directory2',
>   flags: {},
>   successCallback: (e) { ... }
> 
> ???

Done.

Expand Messages | Collapse Messages

Issue 10382176: Add test for DOM fileapi. (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Messages