Issue 10382148: Revert "Fix URL decoding in HTTP library"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10382148: Revert "Fix URL decoding in HTTP library" (Closed)

Created:
8 years, 7 months ago by Søren Gjesse

Modified:
8 years, 7 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Fix URL decoding in HTTP library" Issues with dart2js tests. TBR=ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7600

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -58 lines)			Patch
M	runtime/bin/http_utils.dart	View	1 chunk	+21 lines, -32 lines	1 comment	Download
M	runtime/bin/io.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/standalone/io/http_date_test.dart	View	1 chunk	+6 lines, -8 lines	0 comments	Download
M	tests/standalone/io/url_encoding_test.dart	View	2 chunks	+5 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

8 years, 7 months ago (2012-05-14 10:46:08 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10382148/diff/1/runtime/bin/http_utils...
File runtime/bin/http_utils.dart (right):

https://chromiumcodereview.appspot.com/10382148/diff/1/runtime/bin/http_utils...
runtime/bin/http_utils.dart:12: for (int ii = 0; urlEncoded.length > ii; ++ii) {
Why 'ii' instead of 'i'?

Expand Messages | Collapse Messages