Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 10382137: Refactor the pub tests. (Closed)

Created:
8 years, 7 months ago by nweiz
Modified:
8 years, 7 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Refactor the pub tests. The goal of this refactoring is to make it easier to flexibly set up the filesystem before Pub runs and validate it afterwards. To do so, the pub tests are made more modular by moving creation and validation out of the monolithic testPub method. The declarative philosophy of testPub is maintained. This CL also includes several changes to the unit test library. Most notably, it causes stack traces to be displayed for errors that are thrown during tests. This was first submitted as r7566. That was rolled back due to a test error that is fixed in this CL. Committed: https://code.google.com/p/dart/source/detail?r=7573

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -190 lines) Patch
M lib/unittest/config.dart View 2 chunks +12 lines, -1 line 0 comments Download
M lib/unittest/unittest.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M utils/pub/pub.dart View 2 chunks +16 lines, -16 lines 0 comments Download
M utils/tests/pub/pub_test.dart View 3 chunks +60 lines, -54 lines 0 comments Download
M utils/tests/pub/test_pub.dart View 6 chunks +129 lines, -113 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
nweiz
8 years, 7 months ago (2012-05-11 20:18:35 UTC) #1
Bob Nystrom
8 years, 7 months ago (2012-05-11 23:09:22 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698