Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 10381123: Make dart_api.h C compatible. (Closed)

Created:
8 years, 7 months ago by cshapiro
Modified:
8 years, 7 months ago
Reviewers:
turnidge, Bill Hesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make dart_api.h C compatible. BUG=3024 Committed: https://code.google.com/p/dart/source/detail?r=7666

Patch Set 1 #

Patch Set 2 : prefix structs based on a suggestion from todd #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M runtime/include/dart_api.h View 1 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cshapiro
Tested as follows... $ cat > test.c #include <stdio.h> #include "dart_api.h" int main() { printf("%zd\n", ...
8 years, 7 months ago (2012-05-13 08:16:08 UTC) #1
Bill Hesse
This should be fine, but I would be extremely careful about checking that it does ...
8 years, 7 months ago (2012-05-14 13:28:09 UTC) #2
turnidge
lgtm
8 years, 7 months ago (2012-05-14 17:08:21 UTC) #3
cshapiro
8 years, 7 months ago (2012-05-15 18:39:35 UTC) #4
You are correct, Win32 does not have stdbool.h, nor does it have inttypes.h. 
Those includes are somewhat confusingly on the other side of an #else which
ensure a clean compile on Win32.

Powered by Google App Engine
This is Rietveld 408576698