Support for renaming getters and setters

Support for renaming getters and setters


R=brianwilkerson@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=7492

[Brian Wilkerson, 2012-05-10 14:09:09]

LGTM, assuming that none of my questions require a change

https://chromiumcodereview.appspot.com/10381080/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/10381080/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:1064:
MethodElement getter = fieldElement.getGetter();
Can the getter or setter ever be null? If so, don't we want the node's element
to be the field? How does this interact with code completion?

[scheglov, 2012-05-10 15:09:53]

https://chromiumcodereview.appspot.com/10381080/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/10381080/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:1064:
MethodElement getter = fieldElement.getGetter();
On 2012/05/10 14:09:09, Brian Wilkerson wrote:
> Can the getter or setter ever be null? If so, don't we want the node's element
> to be the field? How does this interact with code completion?

  getter/setter can be null only if there is compilation error.

1. I've added tweak, now we will keep FieldElement, probably this is better than
jus null.

2. I don't see any broken test related to code completion, so probably no
changes for code completion. When I test it manually, it seems to work.

[Brian Wilkerson, 2012-05-10 15:27:37]

LGTM

https://chromiumcodereview.appspot.com/10381080/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/10381080/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:1064:
MethodElement getter = fieldElement.getGetter();
>   getter/setter can be null only if there is compilation error.

That doesn't match my understanding. I thought the setter, at least, was null
for final fields. In any case, it's taken care of.