Issue 10381045: Improve type checking, remove unused stub (removed also in x64 in preparation of porting the better…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10381045: Improve type checking, remove unused stub (removed also in x64 in preparation of porting the better… (Closed)

Created:
8 years, 7 months ago by srdjan

Modified:
8 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Improve type checking, remove unused stub (removed also in x64 in preparation of porting the better type checking code from ia 32 to x64). Committed: https://code.google.com/p/dart/source/detail?r=7399

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -245 lines)			Patch
M	runtime/vm/code_generator.cc	View	1	4 chunks	+27 lines, -22 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1 2	3 chunks	+45 lines, -49 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View		3 chunks	+4 lines, -21 lines	0 comments	Download
M	runtime/vm/stub_code.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View		1 chunk	+0 lines, -68 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View		1 chunk	+0 lines, -80 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10381045/diff/1/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://chromiumcodereview.appspot.com/10381045/diff/1/runtime/vm/code_generator.cc#newcode434 runtime/vm/code_generator.cc:434: AbstractTypeArguments& temp_type_arguments = Why do you need temp_type_arguments ...

8 years, 7 months ago (2012-05-07 21:13:04 UTC) #2

srdjan

8 years, 7 months ago (2012-05-07 21:23:12 UTC) #3

https://chromiumcodereview.appspot.com/10381045/diff/1/runtime/vm/code_genera...
File runtime/vm/code_generator.cc (right):

https://chromiumcodereview.appspot.com/10381045/diff/1/runtime/vm/code_genera...
runtime/vm/code_generator.cc:434: AbstractTypeArguments& temp_type_arguments =
On 2012/05/07 21:13:04, regis wrote:
> Why do you need temp_type_arguments instead of using type_arguments directly?

Good point, eliminating temp_type_arguments.

Expand Messages | Collapse Messages