Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10379012: Code completion improvements. (Closed)

Created:
8 years, 7 months ago by messick
Modified:
8 years, 7 months ago
Reviewers:
Brian Wilkerson
Visibility:
Public.

Description

Code completion improvements. Fixes a number of bugs, including support for library prefixes. Cleans up the code in a few places. Removes many warnings, bringing the total to below 1000. Committed: https://code.google.com/p/dart/source/detail?r=7349

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+621 lines, -388 lines) Patch
M compiler/java/com/google/dart/compiler/ast/LibraryUnit.java View 1 2 2 chunks +27 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/completion/CompletionProposal.java View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java View 1 2 41 chunks +343 lines, -154 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionParser.java View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/InternalCompletionProposal.java View 1 2 7 chunks +12 lines, -10 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ScopedNameFinder.java View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/BlockCompleter.java View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/ClassCompleter.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/FieldCompleter.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/FunctionCompleter.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/IdentifierCompleter.java View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/IfCompleter.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/MethodInvocationCompleter.java View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/NewExpressionCompleter.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/ParameterCompleter.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/PropertyAccessCompleter.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/ReturnCompleter.java View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/SuperConstructorInvocationCompleter.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/TypeCompleter.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/TypeParameterCompleter.java View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/VariableStatementCompleter.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/completion/CompletionEngineTest.java View 1 2 2 chunks +23 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/CompletionProposalCategory.java View 1 2 4 chunks +17 lines, -17 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/CompletionProposalComputerDescriptor.java View 1 2 14 chunks +32 lines, -32 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartNoTypeCompletionProposalComputer.java View 1 2 3 chunks +11 lines, -13 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartTypeCompletionProposalComputer.java View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/HippieProposalComputer.java View 1 2 4 chunks +5 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/LazyDartCompletionProposal.java View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/TemplateCompletionProposalComputer.java View 1 2 5 chunks +18 lines, -18 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/dart/CompletionProposalCollector.java View 1 2 4 chunks +16 lines, -16 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/dart/CompletionProposalLabelProvider.java View 1 2 11 chunks +63 lines, -66 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/dart/DartContentAssistInvocationContext.java View 1 2 4 chunks +5 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/dart/IDartCompletionProposalComputer.java View 1 2 3 chunks +15 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
messick
This is a duplicate of 10291008.
8 years, 7 months ago (2012-05-04 17:08:23 UTC) #1
messick
PTAL
8 years, 7 months ago (2012-05-04 17:39:48 UTC) #2
Brian Wilkerson
LGTM. Once again, I only looked at the most recent delta. I'm assuming that I've ...
8 years, 7 months ago (2012-05-04 17:46:44 UTC) #3
messick
PTAL I made quite a few changes to CompletionEngine. The other files are unchanged, except ...
8 years, 7 months ago (2012-05-04 21:18:11 UTC) #4
Brian Wilkerson
8 years, 7 months ago (2012-05-04 21:27:34 UTC) #5 
LGTM

Powered by Google App Engine
This is Rietveld 408576698