Issue 10378033: Fix findMyName by comparing the kind and not the token to EOF_TOKEN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10378033: Fix findMyName by comparing the kind and not the token to EOF_TOKEN. (Closed)

Created:
8 years, 7 months ago by floitsch

Modified:
8 years, 7 months ago

Reviewers:
ahe, ngeoffray

CC:
reviews_dartlang.org, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix findMyName by comparing the kind and not the token to EOF_TOKEN. Committed: https://code.google.com/p/dart/source/detail?r=7416

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	lib/compiler/implementation/elements/elements.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

Thank you, Florian! LGTM I should write a test for this. Does this happen for ...

8 years, 7 months ago (2012-05-07 19:39:43 UTC) #2

floitsch

8 years, 7 months ago (2012-05-08 14:13:56 UTC) #4

On 2012/05/07 19:39:43, ahe wrote:
> Thank you, Florian!
> 
> LGTM
> 
> I should write a test for this. Does this happen for synthetic (backend)
> elements?
It happens for operators (at least for the index operator).
> 
> Cheers,
> Peter

Expand Messages | Collapse Messages