Issue 10368004: Properly set the element type of literal lists.

Issue 10368004: Properly set the element type of literal lists. (Closed)

Created:
8 years, 7 months ago by regis

Modified:
8 years, 7 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Properly set the element type of literal lists. Add test. Keep element type consistent between growable array and backing array. Fix snapshot reader to set the element type in growable array Remove run time call checking rest argument. Committed: https://code.google.com/p/dart/source/detail?r=7337

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+252 lines, -251 lines)			Patch
M	runtime/lib/error.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/ast.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/code_generator.cc	View	1	3 chunks	+4 lines, -68 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.h	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1	6 chunks	+52 lines, -50 lines	0 comments	Download
M	runtime/vm/code_generator_x64.h	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/code_generator_x64.cc	View	1	6 chunks	+52 lines, -50 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1	7 chunks	+36 lines, -24 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	4 chunks	+4 lines, -9 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	4 chunks	+41 lines, -28 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	4 chunks	+31 lines, -6 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/language/list_literal4_test.dart	View	1	1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM with comments. https://chromiumcodereview.appspot.com/10368004/diff/1/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://chromiumcodereview.appspot.com/10368004/diff/1/runtime/vm/intermediate_language.h#newcode849 runtime/vm/intermediate_language.h:849: class CreateArrayComp : public Computation { ...

8 years, 7 months ago (2012-05-04 00:15:35 UTC) #2

regis

8 years, 7 months ago (2012-05-04 16:33:02 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/10368004/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10368004/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:849: class CreateArrayComp : public
Computation {
On 2012/05/04 00:15:35, srdjan wrote:
> This must  be : public TemplateComputation<1>

As we discussed offline, this may not be the right thing to do, since this
computation also takes the elements as input. We will revisit.

https://chromiumcodereview.appspot.com/10368004/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:864: #endif
On 2012/05/04 00:15:35, srdjan wrote:
> inputs_[0] = value;

Not done.

https://chromiumcodereview.appspot.com/10368004/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:881: Value* element_type_;
On 2012/05/04 00:15:35, srdjan wrote:
> Remove.

Not done.

Expand Messages | Collapse Messages