Issue 10365026: Fix mac debug build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10365026: Fix mac debug build. (Closed)

Created:
8 years, 7 months ago by regis

Modified:
8 years, 7 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix mac debug build. Committed: https://code.google.com/p/dart/source/detail?r=7354

Patch Set 1 #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -9 lines)			Patch
	M	runtime/vm/compiler.cc	View		5 chunks	+22 lines, -9 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://chromiumcodereview.appspot.com/10365026/diff/1/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://chromiumcodereview.appspot.com/10365026/diff/1/runtime/vm/compiler.cc#newcode445 runtime/vm/compiler.cc:445: return Error::null(); Object::null()

8 years, 7 months ago (2012-05-05 00:11:15 UTC) #2

regis

8 years, 7 months ago (2012-05-05 00:24:09 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/10365026/diff/1/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://chromiumcodereview.appspot.com/10365026/diff/1/runtime/vm/compiler.cc...
runtime/vm/compiler.cc:445: return Error::null();
On 2012/05/05 00:11:15, asiva wrote:
> Object::null()

Good point. I'll change it in my next cl.

Expand Messages | Collapse Messages