Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 10363003: Compute function types together with the parameters. (Closed)

Created:
8 years, 7 months ago by karlklose
Modified:
8 years, 7 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Compute function types together with the parameters. This avoids resolving the types of arguments twice. Committed: https://code.google.com/p/dart/source/detail?r=7374

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Move computation of function type. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -65 lines) Patch
M lib/compiler/implementation/compile_time_constants.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/compiler.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/elements/elements.dart View 1 2 5 chunks +29 lines, -27 lines 0 comments Download
M lib/compiler/implementation/emitter.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/native_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/native_handler.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M lib/compiler/implementation/resolver.dart View 1 2 5 chunks +16 lines, -19 lines 0 comments Download
M lib/compiler/implementation/ssa/builder.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M lib/compiler/implementation/ssa/codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/ssa/optimize.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/universe.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
karlklose
8 years, 7 months ago (2012-05-03 13:03:13 UTC) #1
ngeoffray
http://codereview.chromium.org/10363003/diff/2001/lib/compiler/implementation/elements/elements.dart File lib/compiler/implementation/elements/elements.dart (right): http://codereview.chromium.org/10363003/diff/2001/lib/compiler/implementation/elements/elements.dart#newcode506 lib/compiler/implementation/elements/elements.dart:506: Link<Type> parameterTypes; As discussed, we can avoid having this ...
8 years, 7 months ago (2012-05-07 08:36:09 UTC) #2
karlklose
http://codereview.chromium.org/10363003/diff/2001/lib/compiler/implementation/elements/elements.dart File lib/compiler/implementation/elements/elements.dart (right): http://codereview.chromium.org/10363003/diff/2001/lib/compiler/implementation/elements/elements.dart#newcode506 lib/compiler/implementation/elements/elements.dart:506: Link<Type> parameterTypes; On 2012/05/07 08:36:09, ngeoffray wrote: > As ...
8 years, 7 months ago (2012-05-07 09:08:29 UTC) #3
ngeoffray
8 years, 7 months ago (2012-05-07 09:45:59 UTC) #4
LGTM!

Powered by Google App Engine
This is Rietveld 408576698