Issue 10356095: The shift-amount must not be anded with 31.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10356095: The shift-amount must not be anded with 31. (Closed)

Created:
8 years, 7 months ago by floitsch

Modified:
8 years, 7 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, kasperl, Mads Ager (google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

The shift-amount must not be anded with 31. In JS x >> y is equivalent to x >> (y & 31). Dart's semantics is different. Committed: https://code.google.com/p/dart/source/detail?r=7486

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -0 lines)			Patch
M	lib/compiler/implementation/lib/js_helper.dart	View	2 chunks	+6 lines, -0 lines	0 comments	Download
A	tests/language/bit_shift_test.dart	View	1 chunk	+46 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM