Issue 10356053: Prettify !(x rel-op y) into (x "!rel-op" y) when possible.

Issue 10356053: Prettify !(x rel-op y) into (x "!rel-op" y) when possible. (Closed)

Created:
8 years, 7 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 7 months ago

Reviewers:
ngeoffray, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Prettify !(x rel-op y) into (x "!rel-op" y) when possible. Relational operators are equality, identity, and gt[e]/lt[e]. Committed: https://code.google.com/p/dart/source/detail?r=7410

Patch Set 2 : Addressed review comments. #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -8 lines)			Patch
M	lib/compiler/implementation/compile_time_constants.dart	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	lib/compiler/implementation/operations.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View	1	1 chunk	+28 lines, -4 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://chromiumcodereview.appspot.com/10356053/diff/1/lib/compiler/implementation/ssa/codegen.dart File lib/compiler/implementation/ssa/codegen.dart (right): https://chromiumcodereview.appspot.com/10356053/diff/1/lib/compiler/implementation/ssa/codegen.dart#newcode1407 lib/compiler/implementation/ssa/codegen.dart:1407: return; I prefer else if than return. https://chromiumcodereview.appspot.com/10356053/diff/1/lib/compiler/implementation/ssa/codegen.dart#newcode1424 ...

8 years, 7 months ago (2012-05-08 09:27:24 UTC) #2

Lasse Reichstein Nielsen

https://chromiumcodereview.appspot.com/10356053/diff/1/lib/compiler/implementation/ssa/codegen.dart File lib/compiler/implementation/ssa/codegen.dart (right): https://chromiumcodereview.appspot.com/10356053/diff/1/lib/compiler/implementation/ssa/codegen.dart#newcode1407 lib/compiler/implementation/ssa/codegen.dart:1407: return; On 2012/05/08 09:27:24, ngeoffray wrote: > I prefer ...

8 years, 7 months ago (2012-05-08 10:03:33 UTC) #3

sra1

https://chromiumcodereview.appspot.com/10356053/diff/5001/lib/compiler/implementation/ssa/codegen.dart File lib/compiler/implementation/ssa/codegen.dart (right): https://chromiumcodereview.appspot.com/10356053/diff/5001/lib/compiler/implementation/ssa/codegen.dart#newcode1420 lib/compiler/implementation/ssa/codegen.dart:1420: visitInvokeBinary(input, I can't tell from the code, do the ...

8 years, 7 months ago (2012-05-08 17:47:52 UTC) #4

Lasse Reichstein Nielsen

8 years, 7 months ago (2012-05-09 20:13:24 UTC) #5

https://chromiumcodereview.appspot.com/10356053/diff/5001/lib/compiler/implem...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10356053/diff/5001/lib/compiler/implem...
lib/compiler/implementation/ssa/codegen.dart:1420: visitInvokeBinary(input,
Well spotted. No, it's not excluded. I'll have to ensure that the left operand
isn't a double before doing this.

What is NaN === NaN these days?

Expand Messages | Collapse Messages