Issue 10356051: First steps toward a two stages new compiler.

Issue 10356051: First steps toward a two stages new compiler. (Closed)

Created:
8 years, 7 months ago by srdjan

Modified:
8 years, 7 months ago

Reviewers:
regis, Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

First steps toward a two stages new compiler. Committed: https://code.google.com/p/dart/source/detail?r=7420

Patch Set 4 : #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -28 lines)			Patch
M	runtime/vm/code_generator_ia32.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/compiler.cc	View	1	2 chunks	+34 lines, -8 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View		4 chunks	+16 lines, -8 lines	2 comments	Download
M	runtime/vm/flow_graph_compiler_arm.h	View	1 2 3	2 chunks	+6 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.h	View	1 2 3	2 chunks	+6 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1	3 chunks	+5 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	2 chunks	+26 lines, -2 lines	0 comments	Download
M	runtime/vm/instructions_x64_test.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View		3 chunks	+19 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10356051/diff/4003/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://chromiumcodereview.appspot.com/10356051/diff/4003/runtime/vm/flow_graph_builder.cc#newcode1185 runtime/vm/flow_graph_builder.cc:1185: // The context scope may have already been ...

8 years, 7 months ago (2012-05-08 16:07:32 UTC) #3

srdjan

8 years, 7 months ago (2012-05-08 16:16:03 UTC) #4

https://chromiumcodereview.appspot.com/10356051/diff/4003/runtime/vm/flow_gra...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/10356051/diff/4003/runtime/vm/flow_gra...
runtime/vm/flow_graph_builder.cc:1185: // The context scope may have already
been set by the new non-optimizing
On 2012/05/08 16:07:32, regis wrote:
> I would drop "new".

Done in next CL.

Expand Messages | Collapse Messages