Issue 10352012: Using SubtypeTestCache object instead of an array, that way we do not need to patch and can communi…

Issue 10352012: Using SubtypeTestCache object instead of an array, that way we do not need to patch and can communi… (Closed)

Created:
8 years, 7 months ago by srdjan

Modified:
8 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Using SubtypeTestCache object instead of an array, that way we do not need to patch and can communicate to type tests if there is a cache to update (quicker than looking up code). Committed: https://code.google.com/p/dart/source/detail?r=7304

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 8

Patch Set 5 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+323 lines, -181 lines)			Patch
M	runtime/vm/code_generator.h	View	1 2 3 4	1 chunk	+0 lines, -13 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	1 2 3 4	7 chunks	+60 lines, -87 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.h	View	1 2 3 4	2 chunks	+17 lines, -15 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1 2 3 4	13 chunks	+44 lines, -35 lines	0 comments	Download
M	runtime/vm/code_generator_x64.cc	View	1 2 3 4	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3 4	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2 3 4	5 chunks	+48 lines, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3 4	9 chunks	+80 lines, -16 lines	0 comments	Download
M	runtime/vm/object_test.cc	View	1 2 3 4	1 chunk	+23 lines, -0 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 2 3 4	2 chunks	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/raw_object.cc	View	1 2 3 4	1 chunk	+9 lines, -1 line	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	1 2 3 4	1 chunk	+16 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 2 3 4	6 chunks	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10352012/diff/3018/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://chromiumcodereview.appspot.com/10352012/diff/3018/runtime/vm/code_generator.cc#newcode481 runtime/vm/code_generator.cc:481: &last_instance_type_arguments, Interesting indentation https://chromiumcodereview.appspot.com/10352012/diff/3018/runtime/vm/code_generator.cc#newcode507 runtime/vm/code_generator.cc:507: new_cache.raw(), indentation https://chromiumcodereview.appspot.com/10352012/diff/3018/runtime/vm/code_generator.cc#newcode507 ...

8 years, 7 months ago (2012-05-03 20:59:10 UTC) #2

srdjan

8 years, 7 months ago (2012-05-03 21:51:08 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/10352012/diff/3018/runtime/vm/code_gen...
File runtime/vm/code_generator.cc (right):

https://chromiumcodereview.appspot.com/10352012/diff/3018/runtime/vm/code_gen...
runtime/vm/code_generator.cc:481: &last_instance_type_arguments,
On 2012/05/03 20:59:11, regis wrote:
> Interesting indentation

Made it conventional.

https://chromiumcodereview.appspot.com/10352012/diff/3018/runtime/vm/code_gen...
runtime/vm/code_generator.cc:507: new_cache.raw(),
On 2012/05/03 20:59:11, regis wrote:
> indentation

Done.

https://chromiumcodereview.appspot.com/10352012/diff/3018/runtime/vm/code_gen...
runtime/vm/code_generator.cc:507: new_cache.raw(),
On 2012/05/03 20:59:11, regis wrote:
> indentation

Done.

https://chromiumcodereview.appspot.com/10352012/diff/3018/runtime/vm/code_gen...
File runtime/vm/code_generator.h (right):

https://chromiumcodereview.appspot.com/10352012/diff/3018/runtime/vm/code_gen...
runtime/vm/code_generator.h:128: // A subtype test cache is an array remembering
subtype tests for given values.
On 2012/05/03 20:59:11, regis wrote:
> Left over comment.

Removed.

Expand Messages | Collapse Messages