Issue 10345003: Temporary fix for GrowableArray type arguments: use the type arguments stores in GrowableArray inst…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10345003: Temporary fix for GrowableArray type arguments: use the type arguments stores in GrowableArray inst… (Closed)

Created:
8 years, 7 months ago by srdjan

Modified:
8 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Temporary fix for GrowableArray type arguments: use the type arguments stores in GrowableArray instead of the one in the data container (there is a bug that Regis is fixing where data container is always null). Fix assembly subtype cache lookup lookup. Committed: https://code.google.com/p/dart/source/detail?r=7255

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -74 lines)			Patch
M	runtime/vm/code_generator.cc	View	1	3 chunks	+8 lines, -1 line	0 comments	Download
M	runtime/vm/code_generator_ia32.h	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1	6 chunks	+28 lines, -31 lines	0 comments	Download
M	runtime/vm/object.h	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1	1 chunk	+9 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1	2 chunks	+73 lines, -30 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1	1 chunk	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10345003/diff/1/runtime/vm/stub_code_ia32.cc File runtime/vm/stub_code_ia32.cc (right): https://chromiumcodereview.appspot.com/10345003/diff/1/runtime/vm/stub_code_ia32.cc#newcode1899 runtime/vm/stub_code_ia32.cc:1899: // TOS + 1: instance. TOS + 1.5?

8 years, 7 months ago (2012-05-02 20:05:27 UTC) #2

srdjan

8 years, 7 months ago (2012-05-02 20:44:00 UTC) #3

https://chromiumcodereview.appspot.com/10345003/diff/1/runtime/vm/stub_code_i...
File runtime/vm/stub_code_ia32.cc (right):

https://chromiumcodereview.appspot.com/10345003/diff/1/runtime/vm/stub_code_i...
runtime/vm/stub_code_ia32.cc:1899: // TOS + 1: instance.
On 2012/05/02 20:05:27, regis wrote:
> TOS + 1.5?

Done.

Expand Messages | Collapse Messages