Issue 10344025: Forbid zero argument variant of IDBRequest.openCursor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10344025: Forbid zero argument variant of IDBRequest.openCursor. (Closed)

Created:
8 years, 7 months ago by Anton Muhin

Modified:
8 years, 7 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Forbid zero argument variant of IDBRequest.openCursor. R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=7316

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -10 lines)			Patch
	M	lib/dom/idl/dart/dart.idl	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	lib/html/dartium/html_dartium.dart	View		1 chunk	+3 lines, -10 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

https://chromiumcodereview.appspot.com/10344025/diff/1/lib/html/dartium/html_dartium.dart File lib/html/dartium/html_dartium.dart (right): https://chromiumcodereview.appspot.com/10344025/diff/1/lib/html/dartium/html_dartium.dart#newcode10511 lib/html/dartium/html_dartium.dart:10511: + return _wrap(_ptr.openCursor(_unwrap(range), _unwrap(direction))); that should be able to ...

8 years, 7 months ago (2012-05-03 19:15:56 UTC) #2

Anton Muhin

8 years, 7 months ago (2012-05-04 09:49:41 UTC) #3

Turning into TBR as Stephen was apparently with this change.  I'll amend it if I
am overoptimistic.

Expand Messages | Collapse Messages