Create the JavaScript constructor dynamically.

Create the JavaScript constructor dynamically.

Committed: https://code.google.com/p/dart/source/detail?r=7376

[kasperl, 2012-05-07 09:27:53]

LGTM.

[ngeoffray, 2012-05-07 09:42:30]

https://chromiumcodereview.appspot.com/10344021/diff/5001/lib/compiler/implem...
File lib/compiler/implementation/emitter.dart (right):

https://chromiumcodereview.appspot.com/10344021/diff/5001/lib/compiler/implem...
lib/compiler/implementation/emitter.dart:58: // The caller can also pass in the
constructor as a function if needed.
Who needs that?

https://chromiumcodereview.appspot.com/10344021/diff/5001/lib/compiler/implem...
lib/compiler/implementation/emitter.dart:72: if (typeof fields == 'function') {
Since we control the emission, why do we need to support this?

[floitsch, 2012-05-07 12:42:07]

https://chromiumcodereview.appspot.com/10344021/diff/5001/lib/compiler/implem...
File lib/compiler/implementation/emitter.dart (right):

https://chromiumcodereview.appspot.com/10344021/diff/5001/lib/compiler/implem...
lib/compiler/implementation/emitter.dart:58: // The caller can also pass in the
constructor as a function if needed.
On 2012/05/07 09:42:30, ngeoffray wrote:
> Who needs that?

This is in preparation for a future CL. The idea is, that if there is only one
Dart constructor, than we don't need to have a separate JavaScript constructor
but can merge the two.

https://chromiumcodereview.appspot.com/10344021/diff/5001/lib/compiler/implem...
lib/compiler/implementation/emitter.dart:72: if (typeof fields == 'function') {
On 2012/05/07 09:42:30, ngeoffray wrote:
> Since we control the emission, why do we need to support this?

If you prefer I can remove the code for now. (it's just 2 lines after all...)

[ngeoffray, 2012-05-07 12:54:25]

https://chromiumcodereview.appspot.com/10344021/diff/5001/lib/compiler/implem...
File lib/compiler/implementation/emitter.dart (right):

https://chromiumcodereview.appspot.com/10344021/diff/5001/lib/compiler/implem...
lib/compiler/implementation/emitter.dart:72: if (typeof fields == 'function') {
On 2012/05/07 12:42:08, floitsch wrote:
> On 2012/05/07 09:42:30, ngeoffray wrote:
> > Since we control the emission, why do we need to support this?
> 
> If you prefer I can remove the code for now. (it's just 2 lines after all...)

It's fine if you keep it but make sure you'll use it.