Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issue 10339002: Copy identifier names so that we don't hold on to the original source (Closed)

Created:
8 years, 7 months ago by Brian Wilkerson
Modified:
8 years, 7 months ago
Reviewers:
scheglov, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Copy identifier names so that we don't hold on to the original source. If I'm reading the results right, this saves a significant amount of space. Committed: https://code.google.com/p/dart/source/detail?r=7256

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Brian Wilkerson
8 years, 7 months ago (2012-05-02 17:52:29 UTC) #1
scheglov
Well, this may save memory, so LGTM. But we don't know for sure without looking ...
8 years, 7 months ago (2012-05-02 18:03:06 UTC) #2
Brian Wilkerson
8 years, 7 months ago (2012-05-02 18:14:32 UTC) #3
> But we don't know for sure without looking on numbers.

Agreed. If I'm understanding the numbers provided by YourKit, doing the same
thing before and after the change resulted in a decrease (in strongly reachable
retained objects) from 179 MB to 155 MB. (Total memory was more significant,
from 209 MB to 158 MB, but that might be misleading.) It would be great to have
someone confirm those results, and as you said even better if such numbers were
consistently and accurately measured automatically.

Powered by Google App Engine
This is Rietveld 408576698