Issue 10335002: fix vm test configuration to specify vm/cc

Issue 10335002: fix vm test configuration to specify vm/cc (Closed)

Created:
8 years, 7 months ago by Siggi Cherem (dart-lang)

Modified:
8 years, 7 months ago

Reviewers:
Bill Hesse, Emily Fortuna, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

fix vm test configuration to specify vm/cc Committed: https://code.google.com/p/dart/source/detail?r=7254

Patch Set 4 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
M	runtime/tests/vm/test_config.dart	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/tests/vm/vm.status	View	1	2 chunks	+3 lines, -7 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1 2	4 chunks	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

https://chromiumcodereview.appspot.com/10335002/diff/2001/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://chromiumcodereview.appspot.com/10335002/diff/2001/tools/testing/dart/test_suite.dart#newcode117 tools/testing/dart/test_suite.dart:117: suiteName = _suiteName(suiteAndPrefix), I'm not convinced this is the ...

8 years, 7 months ago (2012-05-02 17:47:03 UTC) #1

Emily Fortuna

lgtm, though it is extra work just for one particular case. Will defer to Ivan ...

8 years, 7 months ago (2012-05-02 18:15:27 UTC) #2

Ivan Posva

LGTM with comments. -Ivan https://chromiumcodereview.appspot.com/10335002/diff/2001/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://chromiumcodereview.appspot.com/10335002/diff/2001/tools/testing/dart/test_suite.dart#newcode113 tools/testing/dart/test_suite.dart:113: String suiteAndPrefix, The other option ...

8 years, 7 months ago (2012-05-02 20:05:14 UTC) #3

Siggi Cherem (dart-lang)

8 years, 7 months ago (2012-05-02 20:34:38 UTC) #4

thx.

https://chromiumcodereview.appspot.com/10335002/diff/2001/tools/testing/dart/...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/10335002/diff/2001/tools/testing/dart/...
tools/testing/dart/test_suite.dart:113: String suiteAndPrefix,
On 2012/05/02 20:05:15, Ivan Posva wrote:
> The other option would be to pass an additional parameter, then you can remove
> all of the smarts to split this into pieces.

Done.

https://chromiumcodereview.appspot.com/10335002/diff/2001/tools/testing/dart/...
tools/testing/dart/test_suite.dart:117: suiteName = _suiteName(suiteAndPrefix),
On 2012/05/02 20:05:15, Ivan Posva wrote:
> On 2012/05/02 17:47:03, sigmund wrote:
> > I'm not convinced this is the best approach to do this. In particular, it
> seems
> > that CCTestSuite has a single use (to be extended by VMTestSuite). So this
> > splitting of suite and test-prefix feels overgeneralized. I was
contemplating
> if
> > we should merge the two somehow? Any other suggestions?
> 
> Another option would be that the CCTestSuite expects a prefix of 'cc' by
> default.

Done.

Expand Messages | Collapse Messages