Add a draft of traversing visitor which will analyse function.

Add a draft of traversing visitor which will analyse function.

For now all interesting methods are stubbed out.

R=ahe@google.com,smok@google.com

Committed: https://code.google.com/p/dart/source/detail?r=8317

[Anton Muhin, 2012-05-23 16:58:13]

https://chromiumcodereview.appspot.com/10332315/diff/1/lib/compiler/implement...
File lib/compiler/implementation/compiler.dart (right):

https://chromiumcodereview.appspot.com/10332315/diff/1/lib/compiler/implement...
lib/compiler/implementation/compiler.dart:76: class ReachabilityVisitor
implements Visitor {
I am planning to move this stuff into a separate file in a next change.  Can do
in this one too.

[Roman, 2012-05-24 09:45:48]

https://chromiumcodereview.appspot.com/10332315/diff/1/lib/compiler/implement...
File lib/compiler/implementation/compiler.dart (right):

https://chromiumcodereview.appspot.com/10332315/diff/1/lib/compiler/implement...
lib/compiler/implementation/compiler.dart:76: class ReachabilityVisitor
implements Visitor {
Any comments (dartdocs should I call them?) about this class?

[ahe, 2012-05-24 10:07:05]

https://chromiumcodereview.appspot.com/10332315/diff/1/lib/compiler/implement...
File lib/compiler/implementation/compiler.dart (right):

https://chromiumcodereview.appspot.com/10332315/diff/1/lib/compiler/implement...
lib/compiler/implementation/compiler.dart:76: class ReachabilityVisitor
implements Visitor {
On 2012/05/23 16:58:13, antonmuhin wrote:
> I am planning to move this stuff into a separate file in a next change.  Can
do
> in this one too.

Please do so.

[Anton Muhin, 2012-05-24 14:23:21]

PTAL

https://chromiumcodereview.appspot.com/10332315/diff/1/lib/compiler/implement...
File lib/compiler/implementation/compiler.dart (right):

https://chromiumcodereview.appspot.com/10332315/diff/1/lib/compiler/implement...
lib/compiler/implementation/compiler.dart:76: class ReachabilityVisitor
implements Visitor {
On 2012/05/24 10:07:05, ahe wrote:
> On 2012/05/23 16:58:13, antonmuhin wrote:
> > I am planning to move this stuff into a separate file in a next change.  Can
> do
> > in this one too.
> 
> Please do so.

Done.

[Anton Muhin, 2012-05-25 10:07:25]

friendly ping

[ahe, 2012-06-01 13:55:51]

https://chromiumcodereview.appspot.com/10332315/diff/6001/lib/compiler/implem...
File lib/compiler/implementation/dart_backend.dart (right):

https://chromiumcodereview.appspot.com/10332315/diff/6001/lib/compiler/implem...
lib/compiler/implementation/dart_backend.dart:1: // Copyright (c) 2012, the Dart
project authors.  Please see the AUTHORS file
Move this to a separate directory?

https://chromiumcodereview.appspot.com/10332315/diff/6001/lib/compiler/implem...
lib/compiler/implementation/dart_backend.dart:76: throw new
CompilerCancelledException('not implemented: $reason');
I would prefer if you don't instantiate this exception directly. It is best to
always have a position, because these unimplemented methods have a tendency to
linger on and throw nasty errors in the face of real users (or just your
co-workers).

So you should always use compiler.cancel and pass in something that tracks a
position (in this case, a node).

[Anton Muhin, 2012-06-01 15:09:04]

https://chromiumcodereview.appspot.com/10332315/diff/6001/lib/compiler/implem...
File lib/compiler/implementation/dart_backend.dart (right):

https://chromiumcodereview.appspot.com/10332315/diff/6001/lib/compiler/implem...
lib/compiler/implementation/dart_backend.dart:1: // Copyright (c) 2012, the Dart
project authors.  Please see the AUTHORS file
On 2012/06/01 13:55:51, ahe wrote:
> Move this to a separate directory?

I can easily do it, but maybe (again maybe) let's wait until this file grows big
enough to have at least two files under this dir.

Again, if you think that single file dir is ok, I'll do it immediately.

https://chromiumcodereview.appspot.com/10332315/diff/6001/lib/compiler/implem...
lib/compiler/implementation/dart_backend.dart:76: throw new
CompilerCancelledException('not implemented: $reason');
Peter,

This unimplemented will disappear really soon.

Plus in CL pending in review, this visitor will have a reference to the
compiler, so it'll just redirect to it, so maybe it's ok to keep it in this for
for a very brief time, wdyt?

On 2012/06/01 13:55:51, ahe wrote:
> I would prefer if you don't instantiate this exception directly. It is best to
> always have a position, because these unimplemented methods have a tendency to
> linger on and throw nasty errors in the face of real users (or just your
> co-workers).
> 
> So you should always use compiler.cancel and pass in something that tracks a
> position (in this case, a node).

[ahe, 2012-06-01 16:09:03]

https://chromiumcodereview.appspot.com/10332315/diff/6001/lib/compiler/implem...
File lib/compiler/implementation/dart_backend.dart (right):

https://chromiumcodereview.appspot.com/10332315/diff/6001/lib/compiler/implem...
lib/compiler/implementation/dart_backend.dart:1: // Copyright (c) 2012, the Dart
project authors.  Please see the AUTHORS file
On 2012/06/01 15:09:04, antonmuhin wrote:
> On 2012/06/01 13:55:51, ahe wrote:
> > Move this to a separate directory?
> 
> I can easily do it, but maybe (again maybe) let's wait until this file grows
big
> enough to have at least two files under this dir.
> 
> Again, if you think that single file dir is ok, I'll do it immediately.

I think it would be best with a subdirectory now.

https://chromiumcodereview.appspot.com/10332315/diff/6001/lib/compiler/implem...
lib/compiler/implementation/dart_backend.dart:76: throw new
CompilerCancelledException('not implemented: $reason');
Sounds good.

On 2012/06/01 15:09:04, antonmuhin wrote:
> Peter,
> 
> This unimplemented will disappear really soon.
> 
> Plus in CL pending in review, this visitor will have a reference to the
> compiler, so it'll just redirect to it, so maybe it's ok to keep it in this
for
> for a very brief time, wdyt?
> 
> On 2012/06/01 13:55:51, ahe wrote:
> > I would prefer if you don't instantiate this exception directly. It is best
to
> > always have a position, because these unimplemented methods have a tendency
to
> > linger on and throw nasty errors in the face of real users (or just your
> > co-workers).
> > 
> > So you should always use compiler.cancel and pass in something that tracks a
> > position (in this case, a node).
>

[Anton Muhin, 2012-06-01 16:31:38]

https://chromiumcodereview.appspot.com/10332315/diff/6001/lib/compiler/implem...
File lib/compiler/implementation/dart_backend.dart (right):

https://chromiumcodereview.appspot.com/10332315/diff/6001/lib/compiler/implem...
lib/compiler/implementation/dart_backend.dart:1: // Copyright (c) 2012, the Dart
project authors.  Please see the AUTHORS file
On 2012/06/01 16:09:03, ahe wrote:
> On 2012/06/01 15:09:04, antonmuhin wrote:
> > On 2012/06/01 13:55:51, ahe wrote:
> > > Move this to a separate directory?
> > 
> > I can easily do it, but maybe (again maybe) let's wait until this file grows
> big
> > enough to have at least two files under this dir.
> > 
> > Again, if you think that single file dir is ok, I'll do it immediately.
> 
> I think it would be best with a subdirectory now.

Done.

[ahe, 2012-06-04 08:05:49]

https://chromiumcodereview.appspot.com/10332315/diff/13001/lib/compiler/imple...
File lib/compiler/implementation/leg.dart (right):

https://chromiumcodereview.appspot.com/10332315/diff/13001/lib/compiler/imple...
lib/compiler/implementation/leg.dart:23: #source('dart/backend.dart');
Sorry, I guess I should have been much clearer.

I think the dart backend should be in its own library. Also, I think we
shouldn't use the name "dart" for this backend. This word is too ambiguous in
this context.

I would go with dart_backend and also use that as a library prefix.

[Anton Muhin, 2012-06-04 09:34:23]

https://chromiumcodereview.appspot.com/10332315/diff/13001/lib/compiler/imple...
File lib/compiler/implementation/leg.dart (right):

https://chromiumcodereview.appspot.com/10332315/diff/13001/lib/compiler/imple...
lib/compiler/implementation/leg.dart:23: #source('dart/backend.dart');
Done.  For now I don't import dart_backend w/ a prefix to follow ssa lead.

On 2012/06/04 08:05:49, ahe wrote:
> Sorry, I guess I should have been much clearer.
> 
> I think the dart backend should be in its own library. Also, I think we
> shouldn't use the name "dart" for this backend. This word is too ambiguous in
> this context.
> 
> I would go with dart_backend and also use that as a library prefix.

[ahe, 2012-06-04 10:38:42]

https://chromiumcodereview.appspot.com/10332315/diff/17001/lib/compiler/imple...
File lib/compiler/implementation/leg.dart (right):

https://chromiumcodereview.appspot.com/10332315/diff/17001/lib/compiler/imple...
lib/compiler/implementation/leg.dart:10:
#import('dart_backend/dart_backend.dart');
I think you need to add a prefix. It is correct that the SSA backend doesn't use
a prefix, but when we started this project, there was only one backend. Now that
there is two, it would be nice if they don't have to worry about name clashes.

[Anton Muhin, 2012-06-05 09:50:03]

https://chromiumcodereview.appspot.com/10332315/diff/17001/lib/compiler/imple...
File lib/compiler/implementation/leg.dart (right):

https://chromiumcodereview.appspot.com/10332315/diff/17001/lib/compiler/imple...
lib/compiler/implementation/leg.dart:10:
#import('dart_backend/dart_backend.dart');
On 2012/06/04 10:38:42, ahe wrote:
> I think you need to add a prefix. It is correct that the SSA backend doesn't
use
> a prefix, but when we started this project, there was only one backend. Now
that
> there is two, it would be nice if they don't have to worry about name clashes.

Done.

[ahe, 2012-06-06 09:02:49]

LGTM!