Issue 10332291: Negative numbers should not be >>> shifted.

Issue 10332291: Negative numbers should not be >>> shifted. (Closed)

Created:
8 years, 7 months ago by floitsch

Modified:
8 years, 7 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Negative numbers should not be >>> shifted. Fixes issue 3109. Committed: https://code.google.com/p/dart/source/detail?r=7899

Patch Set 3 : Another bug-fix and comments. #

Total comments: 4

Patch Set 4 : Fix bad English. #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -4 lines)			Patch
	M	lib/compiler/implementation/lib/js_helper.dart	View	1 2 3	1 chunk	+15 lines, -4 lines	0 comments	Download
	M	tests/language/positive_bit_operations_test.dart	View	1 2	4 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://chromiumcodereview.appspot.com/10332291/diff/2001/lib/compiler/implementation/lib/js_helper.dart File lib/compiler/implementation/lib/js_helper.dart (right): https://chromiumcodereview.appspot.com/10332291/diff/2001/lib/compiler/implementation/lib/js_helper.dart#newcode182 lib/compiler/implementation/lib/js_helper.dart:182: return JS('num', @'(# >> #) >>> 0', a, ...

8 years, 7 months ago (2012-05-22 15:46:30 UTC) #2

floitsch

PTAL I fixed another bug in the shift method. https://chromiumcodereview.appspot.com/10332291/diff/2001/lib/compiler/implementation/lib/js_helper.dart File lib/compiler/implementation/lib/js_helper.dart (right): https://chromiumcodereview.appspot.com/10332291/diff/2001/lib/compiler/implementation/lib/js_helper.dart#newcode182 lib/compiler/implementation/lib/js_helper.dart:182: ...

8 years, 7 months ago (2012-05-22 21:07:36 UTC) #3

ngeoffray

LGTM https://chromiumcodereview.appspot.com/10332291/diff/3003/lib/compiler/implementation/lib/js_helper.dart File lib/compiler/implementation/lib/js_helper.dart (right): https://chromiumcodereview.appspot.com/10332291/diff/3003/lib/compiler/implementation/lib/js_helper.dart#newcode184 lib/compiler/implementation/lib/js_helper.dart:184: // that has the 31th bit set would ...

8 years, 7 months ago (2012-05-23 07:17:23 UTC) #4

floitsch

8 years, 7 months ago (2012-05-23 09:28:09 UTC) #5

https://chromiumcodereview.appspot.com/10332291/diff/3003/lib/compiler/implem...
File lib/compiler/implementation/lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/10332291/diff/3003/lib/compiler/implem...
lib/compiler/implementation/lib/js_helper.dart:184: // that has the 31th bit set
would be treated as negative and shift in
On 2012/05/23 07:17:23, ngeoffray wrote:
> 31st

Done.

https://chromiumcodereview.appspot.com/10332291/diff/3003/lib/compiler/implem...
lib/compiler/implementation/lib/js_helper.dart:189: // negative but not have its
31th bit set. The ">>" would then shift in
On 2012/05/23 07:17:23, ngeoffray wrote:
> 31st

Done.

Expand Messages | Collapse Messages