Issue 10332276: Remove compile-time error for unresolved factory names (issue 3079).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10332276: Remove compile-time error for unresolved factory names (issue 3079). (Closed)

Created:
8 years, 7 months ago by regis

Modified:
8 years, 7 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove compile-time error for unresolved factory names (issue 3079). Add test. Committed: https://code.google.com/p/dart/source/detail?r=7822

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -14 lines)			Patch
M	runtime/vm/class_finalizer.cc	View	1	1 chunk	+6 lines, -11 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	tests/language/factory5_test.dart	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1	3 chunks	+2 lines, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/type_variable_bounds_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

lgtm https://chromiumcodereview.appspot.com/10332276/diff/1/tests/language/language_dart2js.status File tests/language/language_dart2js.status (right): https://chromiumcodereview.appspot.com/10332276/diff/1/tests/language/language_dart2js.status#newcode204 tests/language/language_dart2js.status:204: #type_variable_bounds_test/00: Fail, OK # Negative language test. Remove ...

8 years, 7 months ago (2012-05-21 20:23:38 UTC) #2

regis

8 years, 7 months ago (2012-05-21 20:42:56 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/10332276/diff/1/tests/language/languag...
File tests/language/language_dart2js.status (right):

https://chromiumcodereview.appspot.com/10332276/diff/1/tests/language/languag...
tests/language/language_dart2js.status:204: #type_variable_bounds_test/00: Fail,
OK # Negative language test.
On 2012/05/21 20:23:38, hausner wrote:
> Remove this entirely rather than commenting out?

Oops. Done.

Expand Messages | Collapse Messages

Issue 10332276: Remove compile-time error for unresolved factory names (issue 3079). (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages