Issue 10332250: Attempt to fix dart2js redness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10332250: Attempt to fix dart2js redness (Closed)

Created:
8 years, 7 months ago by hausner

Modified:
8 years, 7 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Attempt to fix dart2js redness TBR=lrn Committed: https://code.google.com/p/dart/source/detail?r=7747

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	tests/language/language_dart2js.status	View		3 chunks	+5 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

8 years, 7 months ago (2012-05-21 04:49:08 UTC) #2

LGTM

http://codereview.chromium.org/10332250/diff/1/tests/language/language_dart2j...
File tests/language/language_dart2js.status (right):

http://codereview.chromium.org/10332250/diff/1/tests/language/language_dart2j...
tests/language/language_dart2js.status:215: final_syntax_test/04: Fail
For 03 and 04, the test is:
  Expect.equals(42, F0); /// 03: compile-time error
  Expect.equals(87, F2); /// 04: compile-time error
Couldn't expects be removed and the multi-test comment put directly on the
declarations of F1 and F3?

Expand Messages | Collapse Messages