Issue 10332139: Fix a pair of flow graph construction issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10332139: Fix a pair of flow graph construction issues. (Closed)

Created:
8 years, 7 months ago by Kevin Millikin (Google)

Modified:
8 years, 7 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, Vyacheslav Egorov (Google), Florian Schneider

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix a pair of flow graph construction issues. The stack height was off by one for throw/rethrow. Change throw and rethrow instructions so they never have successors because visiting the graph and iterating nodes manually with StraightLineSuccessor should agree. R=srdjan@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7643

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -67 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.h	View	2 chunks	+6 lines, -8 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 chunk	+9 lines, -58 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

This is needed before computing dominators and inserting phis. We will also need to connect ...

8 years, 7 months ago (2012-05-14 14:23:47 UTC) #1

srdjan

8 years, 7 months ago (2012-05-14 23:39:43 UTC) #3

All catch entries are stored in FlowGraphBuilder::catch_entries_. I am not
certain how we should connect those entries to the graph entry. Florian, Slava?

Expand Messages | Collapse Messages