Issue 10332109: Make the crypto library an official dart:crypto library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10332109: Make the crypto library an official dart:crypto library. (Closed)

Created:
8 years, 7 months ago by Mads Ager (google)

Modified:
8 years, 7 months ago

Reviewers:
dgrove, kasperl, Ivan Posva

CC:
reviews_dartlang.org, Søren Gjesse

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make the crypto library an official dart:crypto library. The library now works on dart2js and on the VM. Add the library to the API docs and to the sdk. R=iposva@google.com,dgrove@google.com,kasperl@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7604

Patch Set 1 #

Patch Set 2 : Fix long line #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+215 lines, -17 lines)			Patch
M	frog/reader.dart	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/library_map.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	lib/crypto/crypto_vm.dart	View		1 chunk	+116 lines, -0 lines	0 comments	Download
M	runtime/bin/bin.gypi	View		6 chunks	+35 lines, -0 lines	0 comments	Download
M	runtime/bin/builtin.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/builtin.cc	View		3 chunks	+10 lines, -1 line	0 comments	Download
M	runtime/bin/builtin_nolib.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	runtime/bin/crypto_sources.gypi	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	runtime/bin/dartutils.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/dartutils.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/bin/gen_snapshot.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	runtime/bin/main.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	tests/lib/crypto/hmac_md5_test.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/lib/crypto/hmac_sha1_test.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/lib/crypto/hmac_sha256_test.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/lib/crypto/sha1_test.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/lib/crypto/sha256_test.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	tools/create_sdk.py	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	utils/apidoc/apidoc.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages