Issue 10332088: Undo optimization in cases where NaN might be involved.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10332088: Undo optimization in cases where NaN might be involved. (Closed)

Created:
8 years, 7 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 7 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Undo optimization in cases where NaN might be involved. Committed: https://code.google.com/p/dart/source/detail?r=7483

Patch Set 2 : Address review comment #

Patch Set 3 : Now with test. #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -1 line)			Patch
	A	frog/tests/leg_only/nan_negate_test.dart	View	1 2	1 chunk	+54 lines, -0 lines	0 comments	Download
	M	lib/compiler/implementation/ssa/codegen.dart	View	1 2	1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

Maybe also add a simple test for Nan? https://chromiumcodereview.appspot.com/10332088/diff/1/lib/compiler/implementation/ssa/codegen.dart File lib/compiler/implementation/ssa/codegen.dart (right): https://chromiumcodereview.appspot.com/10332088/diff/1/lib/compiler/implementation/ssa/codegen.dart#newcode1695 lib/compiler/implementation/ssa/codegen.dart:1695: !input.inputs[0].isTypeUnknown()) ...

8 years, 7 months ago (2012-05-10 10:41:13 UTC) #2

And LGTM