Issue 10331015: Remove ParameterAdapters for bindings classes.

Issue 10331015: Remove ParameterAdapters for bindings classes. (Closed)

Created:
8 years, 7 months ago by podivilov

Modified:
8 years, 7 months ago

Reviewers:
Anton Muhin, antonm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove ParameterAdapters for bindings classes. R=antonm@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=7325

Patch Set 2 : Emit to native conversion in virtual method. #

Total comments: 2

Patch Set 3 : . #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -43 lines)			Patch
M	lib/dom/scripts/generator.py	View	1 2	3 chunks	+51 lines, -8 lines	0 comments	Download
M	lib/dom/scripts/systemnative.py	View	1 2	6 chunks	+13 lines, -34 lines	0 comments	Download
M	lib/dom/templates/dom/native/cpp_callback_header.template	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

https://chromiumcodereview.appspot.com/10331015/diff/1/lib/dom/scripts/systemnative.py File lib/dom/scripts/systemnative.py (right): https://chromiumcodereview.appspot.com/10331015/diff/1/lib/dom/scripts/systemnative.py#newcode738 lib/dom/scripts/systemnative.py:738: emitter.Emit( shouldn't it be a polymorphic method or something?

8 years, 7 months ago (2012-05-03 18:27:50 UTC) #2

podivilov

8 years, 7 months ago (2012-05-03 18:44:19 UTC) #3

Anton Muhin

8 years, 7 months ago (2012-05-04 12:30:50 UTC) #5

LGTM w/ comments addressed

http://codereview.chromium.org/10331015/diff/5001/lib/dom/scripts/systemnativ...
File lib/dom/scripts/systemnative.py (right):

http://codereview.chromium.org/10331015/diff/5001/lib/dom/scripts/systemnativ...
lib/dom/scripts/systemnative.py:724: def _GenerateParameterAdapter(self,
emitter, idl_node, index,
should it still be named _GenerateParameterAdapter

http://codereview.chromium.org/10331015/diff/5001/lib/dom/scripts/systemnativ...
lib/dom/scripts/systemnative.py:731: handle = 'Dart_GetNativeArgument(args, %i)'
% (index + 1)
I've submitted a change already, so you shouldn't need index + 1, but, please,
double check

Expand Messages | Collapse Messages