Issue 10326002: fixes .status of compilers against vm tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10326002: fixes .status of compilers against vm tests. (Closed)

Created:
8 years, 7 months ago by Siggi Cherem (dart-lang)

Modified:
8 years, 7 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

fixes .status of compilers against vm tests. Committed: https://code.google.com/p/dart/source/detail?r=7246

Patch Set 1 #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	runtime/tests/vm/vm.status	View		1 chunk	+5 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm with comment. You didn't give me a chance to review this before submitting! :-) ...

8 years, 7 months ago (2012-05-02 17:00:35 UTC) #2

Siggi Cherem (dart-lang)

On 2012/05/02 17:00:35, Emily Fortuna wrote: > lgtm with comment. > You didn't give me ...

8 years, 7 months ago (2012-05-02 17:31:03 UTC) #3

Siggi Cherem (dart-lang)

8 years, 7 months ago (2012-05-02 17:31:14 UTC) #4

https://chromiumcodereview.appspot.com/10326002/diff/1/runtime/tests/vm/vm.st...
File runtime/tests/vm/vm.status (right):

https://chromiumcodereview.appspot.com/10326002/diff/1/runtime/tests/vm/vm.st...
runtime/tests/vm/vm.status:27: 
On 2012/05/02 17:00:35, Emily Fortuna wrote:
> extra whitespace?

thx, will remove in follow up CL

Expand Messages | Collapse Messages