Issue 10316018: Fix bug in web socket close handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10316018: Fix bug in web socket close handling (Closed)

Created:
8 years, 7 months ago by Søren Gjesse

Modified:
8 years, 7 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix bug in web socket close handling Don't just close the socket when using the output stream for buffering data - some data might not be sent. This was causing the flakiness on Windows. R=ager@google.com BUG=dart:2867 TEST=tests/standalone/io/web_socket_test.dart Committed: https://code.google.com/p/dart/source/detail?r=7280

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -3 lines)			Patch
M	runtime/bin/websocket_impl.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/web_socket_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/standalone.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages