Issue 10315010: Better checking and error reporting for HTTP client

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10315010: Better checking and error reporting for HTTP client (Closed)

Created:
8 years, 7 months ago by Søren Gjesse

Modified:
8 years, 7 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Better checking and error reporting for HTTP client R=ager@google.com BUG=dart:2034 TEST=none Committed: https://code.google.com/p/dart/source/detail?r=7371

Patch Set 1 #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	runtime/bin/http_impl.dart	View		2 chunks	+5 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

lgtm https://chromiumcodereview.appspot.com/10315010/diff/1/runtime/bin/http_impl.dart File runtime/bin/http_impl.dart (right): https://chromiumcodereview.appspot.com/10315010/diff/1/runtime/bin/http_impl.dart#newcode1372 runtime/bin/http_impl.dart:1372: throw new NullPointerException(); We could throw a more ...

8 years, 7 months ago (2012-05-03 13:36:28 UTC) #2

Søren Gjesse

8 years, 7 months ago (2012-05-07 11:42:31 UTC) #3

http://codereview.chromium.org/10315010/diff/1/runtime/bin/http_impl.dart
File runtime/bin/http_impl.dart (right):

http://codereview.chromium.org/10315010/diff/1/runtime/bin/http_impl.dart#new...
runtime/bin/http_impl.dart:1372: throw new NullPointerException();
On 2012/05/03 13:36:28, Mads Ager wrote:
> We could throw a more descriptive error here? Not sure it matters much so I'll
> leave it up to you.
> 
> Is null the only thing we need to check here because other checks are done
> later?

Changed to IllegalArgumentException.

Arguments are type checked later.

Expand Messages | Collapse Messages