Improve the handling of the connection header

Improve the handling of the connection header

* The connection header can now have multiple values
* The persistent connection state can be controlled

R=ajohnsen@google.com

BUG=dart:1995
TEST=tests/standalone/io/http_connection_header_test.dart

Committed: https://code.google.com/p/dart/source/detail?r=7267

[Anders Johnsen, 2012-05-02 07:37:58]

LGTM,

This patch adds a field to request/response that will read/set a header value.
Is this the correct way of doing this? I agree that this is the "nice" way of
exposing it, but we hide what's actually going on by moving this logic from
HttpHeader.

https://chromiumcodereview.appspot.com/10315002/diff/1/tests/standalone/io/ht...
File tests/standalone/io/http_connection_header_test.dart (right):

https://chromiumcodereview.appspot.com/10315002/diff/1/tests/standalone/io/ht...
tests/standalone/io/http_connection_header_test.dart:21: Expect.equals(2,
headers[HttpHeaders.CONNECTION].length);
This looks kind of shaky. Maybe change to a listEquals?

https://chromiumcodereview.appspot.com/10315002/diff/1/tests/standalone/io/ht...
tests/standalone/io/http_connection_header_test.dart:23: Expect.equals(3,
headers[HttpHeaders.CONNECTION].length);
Ditto.

[Søren Gjesse, 2012-05-02 11:56:05]

You did have a point about the field. Changed the code to only operate on the
headers. However I kept the persistentConnection getter and setter as the actual
header values are protocol version dependent.

PTAL

https://chromiumcodereview.appspot.com/10315002/diff/1/tests/standalone/io/ht...
File tests/standalone/io/http_connection_header_test.dart (right):

https://chromiumcodereview.appspot.com/10315002/diff/1/tests/standalone/io/ht...
tests/standalone/io/http_connection_header_test.dart:21: Expect.equals(2,
headers[HttpHeaders.CONNECTION].length);
On 2012/05/02 07:37:58, ajohnsen wrote:
> This looks kind of shaky. Maybe change to a listEquals?

Added check of the actual values.

https://chromiumcodereview.appspot.com/10315002/diff/1/tests/standalone/io/ht...
tests/standalone/io/http_connection_header_test.dart:23: Expect.equals(3,
headers[HttpHeaders.CONNECTION].length);
On 2012/05/02 07:37:58, ajohnsen wrote:
> Ditto.

Ditto.

[Anders Johnsen, 2012-05-02 13:31:48]

LGTM

https://chromiumcodereview.appspot.com/10315002/diff/5/tests/standalone/io/ht...
File tests/standalone/io/http_connection_header_test.dart (right):

https://chromiumcodereview.appspot.com/10315002/diff/5/tests/standalone/io/ht...
tests/standalone/io/http_connection_header_test.dart:20:
headers[HttpHeaders.CONNECTION].some(
I'm not sure what's going on here. headers' operator[] returns a List<String>,
that does not contain a some method. And, it's not wrapped in Expect.isTrue. Am
i missing something? :)

[Søren Gjesse, 2012-05-03 10:30:13]

http://codereview.chromium.org/10315002/diff/5/tests/standalone/io/http_conne...
File tests/standalone/io/http_connection_header_test.dart (right):

http://codereview.chromium.org/10315002/diff/5/tests/standalone/io/http_conne...
tests/standalone/io/http_connection_header_test.dart:20:
headers[HttpHeaders.CONNECTION].some(
On 2012/05/02 13:31:48, ajohnsen wrote:
> I'm not sure what's going on here. headers' operator[] returns a List<String>,
> that does not contain a some method. And, it's not wrapped in Expect.isTrue.
Am
> i missing something? :)

The Expect.isTrue was missing - thanks for spotting that. A List is a Collection
which has the some method.