Issue 10310145: Fix typo in Date.toString.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10310145: Fix typo in Date.toString. (Closed)

Created:
8 years, 7 months ago by floitsch

Modified:
8 years, 7 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix typo in Date.toString. We emitted an extra 0 for Dates that had ms == 10. Fixes issue 1386. Committed: https://code.google.com/p/dart/source/detail?r=7647

Patch Set 2 : Rebase #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -3 lines)			Patch
M	frog/lib/date_implementation.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/lib/mockimpl.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/date.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	tests/corelib/date_time3_test.dart	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://chromiumcodereview.appspot.com/10310145/diff/1/lib/compiler/implementation/lib/mockimpl.dart File lib/compiler/implementation/lib/mockimpl.dart (right): https://chromiumcodereview.appspot.com/10310145/diff/1/lib/compiler/implementation/lib/mockimpl.dart#newcode296 lib/compiler/implementation/lib/mockimpl.dart:296: int hashCode() => value; leftover from the other ...

8 years, 7 months ago (2012-05-15 08:13:09 UTC) #2

floitsch

8 years, 7 months ago (2012-05-15 10:56:15 UTC) #3

https://chromiumcodereview.appspot.com/10310145/diff/1/lib/compiler/implement...
File lib/compiler/implementation/lib/mockimpl.dart (right):

https://chromiumcodereview.appspot.com/10310145/diff/1/lib/compiler/implement...
lib/compiler/implementation/lib/mockimpl.dart:296: int hashCode() => value;
On 2012/05/15 08:13:09, ngeoffray wrote:
> leftover from the other cl

Done.

Expand Messages | Collapse Messages

Issue 10310145: Fix typo in Date.toString. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Messages