Issue 10310037: Fix regression on constant folding an interceptor into a dynamic invocation.

Issue 10310037: Fix regression on constant folding an interceptor into a dynamic invocation. (Closed)

Created:
8 years, 7 months ago by ngeoffray

Modified:
8 years, 7 months ago

Reviewers:
floitsch, mattsh

CC:
reviews_dartlang.org, mattsh, ahe, karlklose, Lasse Reichstein Nielsen, kasperl

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix regression on constant folding an interceptor into a dynamic invocation. Committed: https://code.google.com/p/dart/source/detail?r=7405

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -9 lines)			Patch
M	lib/compiler/implementation/ssa/builder.dart	View	1	4 chunks	+5 lines, -4 lines	0 comments	Download
M	lib/compiler/implementation/ssa/nodes.dart	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/ssa/optimize.dart	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A	tests/language/getter_setter_interceptor_test.dart	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://chromiumcodereview.appspot.com/10310037/diff/1/lib/compiler/implementation/ssa/nodes.dart File lib/compiler/implementation/ssa/nodes.dart (right): https://chromiumcodereview.appspot.com/10310037/diff/1/lib/compiler/implementation/ssa/nodes.dart#newcode1153 lib/compiler/implementation/ssa/nodes.dart:1153: bool this.getter, Since named arguments don't cost anything ...

8 years, 7 months ago (2012-05-07 13:58:32 UTC) #2

mattsh

https://chromiumcodereview.appspot.com/10310037/diff/1/lib/compiler/implementation/ssa/optimize.dart File lib/compiler/implementation/ssa/optimize.dart (right): https://chromiumcodereview.appspot.com/10310037/diff/1/lib/compiler/implementation/ssa/optimize.dart#newcode589 lib/compiler/implementation/ssa/optimize.dart:589: true, just checking - looks like you need to ...

8 years, 7 months ago (2012-05-07 13:58:55 UTC) #3

ngeoffray

8 years, 7 months ago (2012-05-08 07:43:46 UTC) #4

Thanks Florian and Matt

https://chromiumcodereview.appspot.com/10310037/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/10310037/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/nodes.dart:1153: bool this.getter,
On 2012/05/07 13:58:32, floitsch wrote:
> Since named arguments don't cost anything on constructors I would prefer that.
> Alternatively I'm ok with:
> bool isGetter = true;
> bool isSetter = false;
> new HInvokeInterceptor(..., isGetter, isSetter, ...)
> at the call-site.

Added named parameters.

https://chromiumcodereview.appspot.com/10310037/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/optimize.dart (right):

https://chromiumcodereview.appspot.com/10310037/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/optimize.dart:589: true,
On 2012/05/07 13:58:56, mattsh wrote:
> just checking - looks like you need to pass a boolean for the  "setter" as
well,
> no?

Very good catch! Thanks Matt

Expand Messages | Collapse Messages