Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 10308006: Share a tool for listing dependencies thus fixing a dependency problem on Windows. (Closed)

Created:
8 years, 7 months ago by ahe
Modified:
8 years, 7 months ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang), vsm, Anton Muhin, Emily Fortuna, Bob Nystrom
Visibility:
Public.

Description

Share a tool for listing dependencies thus fixing a dependency problem on Windows. Committed: https://code.google.com/p/dart/source/detail?r=7227

Patch Set 1 #

Patch Set 2 : Spotted another Windows bug #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -73 lines) Patch
M dart/dart.gyp View 1 chunk +5 lines, -7 lines 0 comments Download
M dart/frog/dart-frog.gyp View 1 chunk +1 line, -1 line 0 comments Download
D dart/frog/scripts/list_frog_files.py View 1 chunk +0 lines, -27 lines 0 comments Download
A dart/tools/list_files.py View 1 1 chunk +31 lines, -0 lines 2 comments Download
M dart/utils/apidoc/apidoc.gyp View 1 chunk +1 line, -1 line 0 comments Download
D dart/utils/apidoc/scripts/list_files.py View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ahe
CC'ing a bunch of people that might be interested in or impacted by this CL. ...
8 years, 7 months ago (2012-05-02 10:37:09 UTC) #1
kasperl
LGTM.
8 years, 7 months ago (2012-05-02 10:42:51 UTC) #2
ngeoffray
LGTM https://chromiumcodereview.appspot.com/10308006/diff/2001/dart/tools/list_files.py File dart/tools/list_files.py (right): https://chromiumcodereview.appspot.com/10308006/diff/2001/dart/tools/list_files.py#newcode22 dart/tools/list_files.py:22: directories.remove('.svn') Maybe that's because I don't know python ...
8 years, 7 months ago (2012-05-02 11:00:41 UTC) #3
ahe
Hi Kasper and Nicolas, Thank you for taking a look! Cheers, Peter https://chromiumcodereview.appspot.com/10308006/diff/2001/dart/tools/list_files.py File dart/tools/list_files.py ...
8 years, 7 months ago (2012-05-02 11:04:32 UTC) #4
Bob Nystrom
8 years, 7 months ago (2012-05-02 16:32:29 UTC) #5
LGTM, very nice.

Powered by Google App Engine
This is Rietveld 408576698